Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter to allow plugins override block attributes #11730

Closed
wants to merge 6 commits into from
Closed

Filter to allow plugins override block attributes #11730

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9bcb493
Filter to allow plugins override block attributes
kkarpieszuk Nov 11, 2018
d5433d9
Added WP_Block_Type argument, fixed formatting to meet WP coding stan…
kkarpieszuk Nov 11, 2018
69f1f1a
Fixed phpdoc: better param aligment and fixed name of one of params
kkarpieszuk Nov 13, 2018
2bd3c00
Renamed filter to block_prepared_attributes
kkarpieszuk Nov 13, 2018
eff9581
Fixed phpdoc: better param aligment
kkarpieszuk Nov 13, 2018
9ebaffd
Upgraded @since version, removed whitespaces from ends of lines
kkarpieszuk Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/class-wp-block-type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,16 @@ public function prepare_attributes_for_render( $attributes ) {
$prepared_attributes[ $attribute_name ] = $value;
}

/**
* Filter to allow plugins to override block attributes
swissspidy marked this conversation as resolved.
Show resolved Hide resolved
*
* @since 3.5.0
kkarpieszuk marked this conversation as resolved.
Show resolved Hide resolved
*
* @param array $prepared_attributes block attributes
kkarpieszuk marked this conversation as resolved.
Show resolved Hide resolved
*/

kkarpieszuk marked this conversation as resolved.
Show resolved Hide resolved
$prepared_attributes = apply_filters( 'block_attributes', $prepared_attributes );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO $this should be passed to the filter as well. Otherwise one has no idea which block type the attributes are for.

Copy link
Member

@gziolo gziolo Nov 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't it pass the block name instead of $this? What other information plugins would need? It feels like there is no need to pass the block type object by reference.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I second idea to pass the whole object. Mind it, plugin authors will filter not only core Blocks but also many 3rd party with who knows what kind of data. Sometimes it will be helpful to have bigger picture inside of the hook.

But finally it is up to you, I can change but please decide :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 It will be more useful to be given the whole object here instead of the "block type name".


return $prepared_attributes;
}

Expand Down