chore: Improve undo/redo no-op #11428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
approved these changes
Nov 6, 2018
| } | ||
| }, | ||
| withDispatch( ( dispatch ) => ( { | ||
| redo: () => dispatch( 'core/editor' ).redo(), |
There was a problem hiding this comment.
nitpick: can we simplify to redo: dispatch( 'core/editor' ).redo,?
There was a problem hiding this comment.
It was like that before I made the change, though I'm not immediately sure why. I'll give it a shot.
There was a problem hiding this comment.
Tried it and it worked, cool 👍
| } | ||
| }, | ||
| withDispatch( ( dispatch ) => ( { | ||
| undo: () => dispatch( 'core/editor' ).undo(), |
There was a problem hiding this comment.
Same situation as the redo case.
daniloercoli
added a commit
that referenced
this pull request
Nov 8, 2018
…rnmobile/fix-merge-content-not-refreshed-UI * 'master' of https://github.com/WordPress/gutenberg: Add missing tests for Format API code (#11562) chore: Improve undo/redo no-op (#11428) Fix: Contrast checker: Consider fontSize large when size >= 24px instead of >= 18px (#9268)
mtias
added
the
[Focus] Accessibility (a11y)
This was referenced Jun 20, 2023
This was referenced Nov 27, 2023
This was referenced Mar 22, 2024
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small tweak to how we manage the disabled/
onClicknature of the undo/redo buttons.See: #11379 (comment)