-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio documentation: updating radio readme #11226
Conversation
Initial commit to update Radio readme. These changes add design documentation.
Updating the path of the images. Making a small tweak to phrasing.
Thanks for the review @chrisvanpatten. I would love some a11y guidance on the alt text and use of headers. I wasn't sure about how to write alt text for an image with a visible caption. I know some sites use the same caption text for the alt text, but make sure that it's not read twice. Sounds like next steps for this would be:
|
I just read this to get a better handle on alt text and captions: https://webaim.org/techniques/alttext/ I'm still not sure, but leaving the alt text blank might be a valid approach because of the surrounding text. Another possibility is describing what is going on in the diagram. So, for example, this image: the alt text could be: "A diagram of an interface using checkboxes when only one item can be selected from a list." |
Hi @drw158! Happy to share some guidance. Love that you're thinking about this, and asking great questions. ❤️ First, for the headings:
For the alt attributes:
|
I agree with @davidakennedy in the previous comment. Although I can't really see the context of the image and surrounding text. If alt is needed it could be like "Post visibility checkboxes: public, private, and password protected." @drw158 Any change to update the PR? |
The alt text for these images has been removed because removing the images from the document doesn't affect comprehension.
@samikeijonen Can you explain what you mean when you say you can't see the context of the image? @chrisvanpatten all of your concerns should be fixed I'm not sure where the images should be uploaded. That is the only blocker right now. |
Image issue has been resolved. Now ready for a final review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement so I'm gonna say let's go for it.
|
||
When using radio buttons **one should be selected by default** (i.e., when the page loads, in the case of a web application). | ||
|
||
**User control** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are headers, not paragraph text; they should be labelled with header markdown (eg ##### User control
), not bold text like this. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and I'm glad we're using make/design for image uploads!
* Updating Radio readme Initial commit to update Radio readme. These changes add design documentation. * Adding readme images * Image path update Updating the path of the images. Making a small tweak to phrasing. * Updates so that only a single h1 is present * image alt text removal The alt text for these images has been removed because removing the images from the document doesn't affect comprehension. * Removing images * Removing images * Removing images * Adding images hosted on wordpress.org * docs: tweak some usage recommendations * Tweak spacing * docs: Use headers
* Updating Radio readme Initial commit to update Radio readme. These changes add design documentation. * Adding readme images * Image path update Updating the path of the images. Making a small tweak to phrasing. * Updates so that only a single h1 is present * image alt text removal The alt text for these images has been removed because removing the images from the document doesn't affect comprehension. * Removing images * Removing images * Removing images * Adding images hosted on wordpress.org * docs: tweak some usage recommendations * Tweak spacing * docs: Use headers
Initial commit to update Radio readme. These changes add design documentation.
Description
This PR adds design guideline documentation in addition to the development documentation that existed previously. These guidelines are 'best practices' for the usage of the component, as well as describing the component in more detail.
Screenshots
A preview can be seen here, although it doesn't represent what it will look like in the handbook:
http://simp.ly/p/qzstJq
Feedback
I'd appreciate feedback on:
h1
headerThank you!