-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichText: fix format placeholder #11102
Conversation
packages/rich-text/src/to-tree.js
Outdated
@@ -127,6 +140,18 @@ export function toTree( value, multilineTag, settings ) { | |||
} | |||
} | |||
|
|||
if ( isEditableTree && formatPlaceholder && formatPlaceholder.index === i + 1 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic needs to be unduplicated.
This doesn't appear to fix the issue for me:
|
d4f397c
to
0993a6b
Compare
@youknowriad I can't reproduce the bug. :/ |
Not sure what happened in my initial testing, this does fix the issue indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I can confirm that the original issue was fixed. I have two more issues to report. I will do it separately. |
…rnmobile/port-quote-block-step-1 * 'master' of https://github.com/WordPress/gutenberg: (21 commits) Fix property path on get() call (#10962) Fixed typos on block api documentation (#11298) Export `switchToBlockType` to be used mobile side when merging two blocks. (#11294) RichText: Remove unused `ref` assignment to RichText (#11222) Remove findDOMNode from Tooltip component (#11169) Components: Remove redundant onClickOutside handler from Dropdown (#11253) added myself to the contributors list (#11260) Add complete post type labels for Resuable Blocks (#11278) Increase specificity for active radio/checkbox input styling (#11290) Fixed "artifact" misspelling in docs. (#11291) Nux package: fix incorrect named deprecated import (#11283) Rename parentClientId to rootClientId for consistency (#11274) chore(release): update changelog files chore(release): publish Update plugin version to 4.2.0. (#11258) Data: Use turbo-combine-reducers in place of Redux (#11255) Revert using Icon in IconButton to avoid regression in plugin icons (pinned icons) (#11256) Block List: Use default Inserter for sibling insertion (#11018) Editor: Optimize Inserter props generation and reconciliation (#11243) RichText: fix format placeholder (#11102) ... # Conflicts: # packages/block-library/src/quote/index.js
Description
This branch fixes a few related issues:
The only solution for applying a format placeholder is to temporarily store an extra property on the value object that indicates to the editable tree creator that a format placeholder should appear there with the caret.
I added an e2e test to verify it works.
How has this been tested?
Ensure you can type while using formatting shortcuts (see e2e test). Ensure #10209 (comment) is not reproducible.
Screenshots
Types of changes
Bug fix.
Checklist: