DateTimePicker component: Use color function for defining the background #10943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
I'm not exactly sure how to test this in Gutenberg (@mmtr feel free to add a Testing Instructions section and maybe some before/after screenshots), but the lack of color function was definitely an error and this PR fixes it. ✨
Sorry about that, @Copons! I just added the instructions below: Testing instructions
I don't think screenshots are needed here since we have not changed visually anything. |
vindl
approved these changes
Oct 23, 2018
gziolo
added
[Type] Bug
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last version of the
@wordpress/componentspackage provides an CSS file with invalid syntax because there isbackgroundproperty with a wrong value for theDateTimePickercomponent.It seems that it was forgotten to include the
colorfunction on #7621, as this function will create a new color by adjusting it with the givenshade.This PR adds that function, so we can solve the import problems we have on Calypso using the latest packages.
How has this been tested?
I tested locally by generating a build and checking that the built CSS include a valid background value.
Testing instructions
npm run build:packagespackages/components/build-style/style.cssdoesn't include anyshade, specially thebackgroundproperties between lines 1615 and 1629.Types of changes
Bug fix
Checklist: