Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selector import #10330

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Fix selector import #10330

merged 1 commit into from
Oct 4, 2018

Conversation

oandregal
Copy link
Member

In #10201 I forgot to rename the selector.

@oandregal oandregal self-assigned this Oct 4, 2018
@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label Oct 4, 2018
@oandregal oandregal added this to the 4.0 milestone Oct 4, 2018
@oandregal oandregal requested a review from youknowriad October 4, 2018 14:40
youknowriad
youknowriad approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to see if we can add an e2e test for Drag and Drop (Could be done later)

@oandregal oandregal merged commit 0332aa9 into master Oct 4, 2018
@oandregal oandregal deleted the fix/selector-clientids-descendants branch October 4, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees

@oandregal oandregal

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @youknowriad