Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service icons still missing for numerous core embeds #9124

Open
maddisondesigns opened this issue Aug 18, 2018 · 7 comments
Open

Service icons still missing for numerous core embeds #9124

maddisondesigns opened this issue Aug 18, 2018 · 7 comments
Assignees
Labels
[Block] Embed Affects the Embed Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@maddisondesigns
Copy link

Describe the bug
Some of the core embeds now have their appropriate logos but there are still numerous that dont.

Icons are still missing for the following core embeds:

Animoto
Cloudup
CollegeHumor
DailyMotion
Funny Or Die
Hulu
Imgur
Issuu
Kickstarter
Meetup
Mixcloud
Photobucket
Polldaddy
ReverbNation
Screencast
Scribd
Slideshare
SmugMug
SoundCloud
Speaker
TED
VideoPress
WordPress.TV

Desktop (please complete the following information):

  • OS: macOS Sierra 10.12.6
  • Browser: Firefox Quantum 61.0.2 (64-bit)
  • Gutenberg: 3.6.2
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback. labels Aug 18, 2018
@karmatosed
Copy link
Member

Totally agree we should add those that we can, let's get a PR made up - are you interested in doing that @maddisondesigns?

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Aug 19, 2018
@maddisondesigns
Copy link
Author

With current client work, I don't have time to put together a PR myself, sorry.

@chrisvanpatten chrisvanpatten self-assigned this Aug 21, 2018
@chrisvanpatten
Copy link
Contributor

@karmatosed I'll tackle as many of these as I can easily find :)

@enriquesanchez
Copy link
Contributor

enriquesanchez commented Apr 24, 2020

These are still in need of an icon as of today, Gutenberg v7.9.1

Animoto
Cloudup
CollegeHumor (no longer available)
Crowdsignal (new since last check)
DailyMotion
Funny Or Die (no longer available)
Hulu
Imgur
Issuu
Kickstarter
Meetup
Mixcloud
Photobucket (no longer available)
Polldaddy (no longer available)
ReverbNation
Screencast
Scribd
Slideshare
SmugMug
SoundCloud
Speaker Deck
TED
VideoPress
WordPress.TV

@skorasaurus
Copy link
Member

skorasaurus commented Apr 12, 2021

here are the ones that still need icons as of today:

Cloudup
Crowdsignal
Imgur
Issuu - probably no longer applicable; requires pro account to embed now.
Kickstarter
Meetup
Mixcloud
ReverbNation
Screencast
Scribd
Slideshare
SmugMug
SoundCloud
Speaker Deck
TED
VideoPress
WordPress.TV

@t-hamano
Copy link
Contributor

I would suggest to improve the consistency of icons in the embed blocks by applying the following approach:

  • Don’t use colored icons.
  • If an SVG of the Social Icon block exists, use it to update the icons.
  • If the brand provides an SVG logo, use it to update the icons.
  • If there is no suitable brand logo, apply one of the following icons:
    Image

cc @WordPress/gutenberg-design

@jasmussen
Copy link
Contributor

I would echo point by point Aki's suggestions, however I also know that there are diverging thoughts on the best path forward (especially around color), so would welcome broader feedback. I'm here to help with icons if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

8 participants