Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server side attribute validation fails silently #7653

Closed
andreilupu opened this issue Jul 1, 2018 · 1 comment
Closed

Server side attribute validation fails silently #7653

andreilupu opened this issue Jul 1, 2018 · 1 comment
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Package] Server Side Render /packages/server-side-render [Status] Not Implemented Issue/PR we will (likely) not implement.

Comments

@andreilupu
Copy link
Contributor

Describe the bug
I've noticed that the method prepare_attributes_for_render doesn't scream when an attribute doesn't have an expected type.
For example, the RichText component saves the value as an array of strings, even if I've defined the attribute as string. In this case, the value of the attribute in the render_callback comes empty without noticing a problem in the process.

Expected behavior
I think that by triggering a Notice would be helpful for developers to catch early architectural issues.

Additional context

  • I've used the master branch of this repo
  • I can provide a PR but I'm not sure if this is the expected behavior or not.
@ajitbohra ajitbohra added the [Package] Server Side Render /packages/server-side-render label Jul 1, 2018
andreilupu added a commit to andreilupu/gutenberg that referenced this issue Jul 8, 2018
@andreilupu
Add a _doing_it_wrong message when an attribute value is wrong typed.
8aa6204 
For WordPress#7653
@andreilupu andreilupu mentioned this issue Jul 8, 2018
Closed
4 tasks
@aduth aduth added the [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f label Oct 22, 2018
@gziolo
Copy link
Member

gziolo commented Jan 31, 2019

As noted in the corresponding PR, these functionalities are no longer part of Gutenberg because they were moved to WordPress core. Those changes should be proposed for inclusion in WordPress core using Trac: https://core.trac.wordpress.org/newticket

Would you mind moving it there? I'm closing this issue as no longer relevant for the Gutenberg plugin.

@gziolo gziolo closed this as completed Jan 31, 2019
@gziolo gziolo added the [Status] Not Implemented Issue/PR we will (likely) not implement. label Jan 31, 2019
@aduth aduth mentioned this issue Apr 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Package] Server Side Render /packages/server-side-render [Status] Not Implemented Issue/PR we will (likely) not implement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gziolo @ajitbohra @aduth @andreilupu