Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to update jest snapshots #7513

Closed
tofumatt opened this issue Jun 23, 2018 · 0 comments
Closed

Add script to update jest snapshots #7513

tofumatt opened this issue Jun 23, 2018 · 0 comments
Assignees
@tofumatt
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Milestone
3.2

Comments

@tofumatt
Copy link
Member

If you want to update snapshots and you aren't familiar with jest snapshots, you'll usually wind up at the Jest Snapshots page. Running jest directly inside the project, as suggested, leads to errors and I find it annoying to have to pass arguments to npm scripts, etc.

I think we should just have a script that updates snapshots, it would be easier for new developers and experienced ones alike.
@tofumatt tofumatt added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 23, 2018
@tofumatt tofumatt added this to the 3.2 milestone Jun 23, 2018
@tofumatt tofumatt self-assigned this Jun 23, 2018
tofumatt added a commit that referenced this issue Jun 23, 2018
@tofumatt
feat: Add snapshot update script
1f92a52 
Fixes #7513
@tofumatt tofumatt mentioned this issue Jun 23, 2018
Merged
ntwb pushed a commit that referenced this issue Jun 24, 2018
@tofumatt @ntwb
feat: Add snapshot update script (#7514)
b299f4f 
Fixes #7513

## Description
Adds a script to update any snapshots that have changed.

## How has this been tested?
I used this in a recent PR where my snapshots changed; figured it might be useful to others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
1 participant
@tofumatt