Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalinks editing has vanished #7467

Closed
karmatosed opened this issue Jun 22, 2018 · 3 comments · Fixed by #7494
Closed

Permalinks editing has vanished #7467

karmatosed opened this issue Jun 22, 2018 · 3 comments · Fixed by #7494
Assignees
@tofumatt
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Milestone
3.2

Comments

@karmatosed
Copy link
Member

Right now on master the permalink editing has gone:

2018-06-22 at 11 26
@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels Jun 22, 2018
@karmatosed karmatosed added this to the 3.2 milestone Jun 22, 2018
@tofumatt tofumatt self-assigned this Jun 22, 2018
@afercia afercia mentioned this issue Jun 22, 2018
Closed
@tofumatt
Copy link
Member

After git bisecting things it looks like 1f9d0b4 is the culprit commit. Checking into things now and trying to fix it.

tofumatt added a commit that referenced this issue Jun 22, 2018
@tofumatt
fix: Show permalink editor in editor (fix #7467)
b7881ea
@tofumatt tofumatt mentioned this issue Jun 22, 2018
Merged
4 tasks
tofumatt added a commit that referenced this issue Jun 25, 2018
@tofumatt
fix: Show permalink editor in editor (fix #7467)
3ac5db6
tofumatt added a commit that referenced this issue Jun 26, 2018
@tofumatt
fix: Show permalink editor in editor (#7494)
04c0ea2 
* fix: Show permalink editor in editor (fix #7467)
* Use getCurrentPost() to get the link
@aduth
Copy link
Member

aduth commented Jun 26, 2018

We should consider adding an end-to-end test to verify that permalinks editing works as expected.

@tofumatt tofumatt mentioned this issue Jun 26, 2018
Closed
@tofumatt
Copy link
Member

Agreed, filed #7554.

@designsimply designsimply added the [Feature] Permalink The permalink of a post or page and the experience of setting or editing it label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

fix: Show permalink editor in editor WordPress/gutenberg
4 participants
@tofumatt @karmatosed @designsimply @aduth