Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post content block should not be selectable in write mode with template rendered #67129

Open
Tracked by #60021
richtabor opened this issue Nov 19, 2024 · 3 comments · May be fixed by #67149
Open
Tracked by #60021

Post content block should not be selectable in write mode with template rendered #67129

richtabor opened this issue Nov 19, 2024 · 3 comments · May be fixed by #67149
Assignees
Labels
[Feature] Write mode [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

When viewing a page with a template rendered, the write mode tool is available.

When active, I would not expect to be able to select, and edit, the post content block. I'm not editing the template here (and saving does not reflect any of the changes, as expected, since those are not valid).

CleanShot.2024-11-19.at.13.43.03.mp4
@richtabor richtabor added [Feature] Write mode [Type] Bug An existing feature does not function as intended labels Nov 19, 2024
@richtabor richtabor changed the title I should not be able to select the content block when in write mode Post content block should not be selectable in write mode with template rendered Nov 19, 2024
@yogeshbhutkar
Copy link
Contributor

Hi @richtabor, thanks for reporting the issue. I was able to reproduce the bug. Would like to fix it with a corresponding PR. Thanks!

@richtabor
Copy link
Member Author

Note that if the post content block is selectable, the inserter tries to add the next block below it (which it can't, as we're not editing the template). Another +1 for making the post content not a selectable block unless you're editing the template perhaps.

CleanShot.2024-11-21.at.18.30.20.mp4

@richtabor
Copy link
Member Author

One also has to be careful about how many times you command + a to select all, which the further you're nested the hardest it is to guess what count is one too many:

CleanShot.2024-11-21.at.18.34.05.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Write mode [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
2 participants