package.json already contains stone age old obsolete wp-env configuration

[lgersman]

Description

the monorepo package.json already contains obsolete wp-env configuration

"wp-env": {
	"plugin-dir": "gutenberg",
	"plugin-name": "Gutenberg",
	"docker-template": "./bin/docker-compose.override.yml.template",
	"welcome-logo": [
		",⁻⁻⁻·       .                 |",
		"|  ،⁓’.   . |---  ,---. ,---. |---. ,---. ,---. ,---.",
		"|   | |   | |     |---' |   | |   | |---' |     |   |",
		"`---' `---' `---’ `---’ '   ` `---' `---’ `     `---|",
		"                                                `---'"
	],
	"welcome-build-command": "npm run dev"
}

git blame told me that these snippet is from 2019. I could not find anymore references to "docker-template" nor "welcome-build-command" in the @wordpress/env command. Seems these config was simply forgotten to be removed. Even the referenced wp-env template file (https://github.com/WordPress/gutenberg/blob/trunk/bin/docker-compose.override.yml.template) is no more in use.

The actual used wp-env configuration is located in file .wp-env.json.

So the wp-env configuration snippet in root package.json can be removed.

Step-by-step reproduction instructions

1. removed the wp-env configuration snippet in root package.json

2. deleted the wp-env configuration template file bin/docker-compose.override.yml.template referenced in the wp-env configuration snippet in root package.json

3. Did a npm ci, npm run build and finally npm run env start.

WordPress including Gutenberg worked like a charm.

So this code can safely be removed from my opinion.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[talldan]

Good catch! This is from an older version of wp-env.

[lgersman]

Yeah, I actually stumbled across the issue while borrowing some configs for my own Gutenberg based project 🤪

Thought "Hmmmm ... I know these settings from many many years ago - this cannot be used anymore." And yes, it was true.

Next time I better do a pull request fixing the issue - costs approximately the same time 🤓