Pattern details: change info to "Overrides enabled"

[bph]

Description

In the site editor, looking at a synch pattern with enabled overrides, the info still displayed "Fully synched" rather then 'Overrides enabled' or a similar copy

Step-by-step reproduction instructions

• Site editor
• Create a synched pattern with a headline and a paragraph
• Edit Original
• Select a block and enable "Allow instance overrides" from the Advanced section.
• Go back to site editor menu
• Go to Patterns > My Patterns
• click on the new pattern
• The pattern info shows "Fully synched"

Screenshots, screen recording, code snippet

Environment info

WordPress 6.4.3
Gutenberg Nightly v. 17.8.20240206
Twenty-Twenty-Four theme

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[talldan]

Good point. The pattern is still synced, though perhaps the word 'Fully' is misleading and could be changed. Maybe simplifying it to 'Synced' to match what's shown when creating the pattern could be an option:

Showing some additional details about the overrides could be another enhancement, I think that could need some design feedback, so I've added the label.

[bph]

Thanks @talldan, for looking at it. Yes, indeed, the part that's misleading is the "Fully" word. The feature is powerful, and a content creator would need to know which pattern can be used how, so a first iteration would just be a change of words before adding additional details to the info section.

[bph]

Another idea is to update the preview with the light-blue outline for the content blocks that allow instance overrides. Then the preview would visually clear up the lack of information

[talldan]

In #58876, I'm removing the word 'Fully'. After merging that I'll leave this issue open for discussion on further improvements.

[getdave]

@talldan Thanks for your PR 👍

Can I check how difficult it would be to add some kind of indicator that "Overrides enabled" is active on a pattern? I'm assuming it's a property that we can use to conditionally render some text?

It it's relatively simple it seems like it would be a good addition to 6.5. If not then I'd like to remove this Issue from the board.

[talldan]

@getdave Right now it is possible, it requires parsing all blocks in the pattern and checking for the presence of the block bindings in the attributes of the blocks. So feasible, but not computationally cheap or completely straightforward.

[getdave]

Thanks Dan. Ok, let's leave this one open for now and see what level of feedback we receive around this during Beta 1.

[annezazu]

Of note, I can see this being something folks want to filter by in Data Views as well so we should plan for it in the future.

[carolinan]

The pattern detail sidebar that is described and screenshotted in this issue has been removed.
When editing a synced pattern, the synced status shows as "synced:

Is there anything actionable left to do or is this issue solved?

[annezazu]

The only thing remaining in my mind is to show overrides in the inspector.

[talldan]

The only thing remaining in my mind is to show overrides in the inspector.

@annezazu Could you elaborate on that? They are in the inspector, shown in the screenshot above.

[annezazu]

It's not showing if there are overrides though. It's just showing sync status as synced!

[talldan]

There's a separate panel for any overrides, does there need to be more info than that?

[annezazu]

I’d want to see if a pattern has overrides, including being able to sort them in data views. That might just be me though. Feel free to close out and another issue can always be opened if the feedback resurfaces.

…

On Wednesday, June 5, 2024, Daniel Richards ***@***.***> wrote: There's a separate panel for any overrides, does there need to be more info than that? — Reply to this email directly, view it on GitHub <#58725 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGN7BE3CNJPVT5Q26N3NCJTZF7LN3AVCNFSM6AAAAABC34VXJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJRGM2TMMRVGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Anne McCarthy* Product Wrangler Pronouns <https://www.hrc.org/resources/talking-about-pronouns-in-the-workplace>: she/her/hers | they/them/theirs (use either interchangeably)

[talldan]

I thought we were discussing the inspector. In the inspector a user can already see if there are overrides using the 'Overrides' panel.

I think data views should be a separate issue, as it isn't mentioned in the issue description here, and it'd be a much more complicated dev task.

[talldan]

I see the data views aspect is already tracked in #58988