Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable duotone until media is provided in Cover block #48804

Open
richtabor opened this issue Mar 6, 2023 · 0 comments · May be fixed by #54451
Open

Disable duotone until media is provided in Cover block #48804

richtabor opened this issue Mar 6, 2023 · 0 comments · May be fixed by #54451
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

Description

The duotone control does not take affect unless there is media supplied to the Cover block. As-is, you can set a duotone value without meeting that requirement — which provides no visual feedback & feels like a loose end we can easily clean up.

Step-by-step reproduction instructions

  1. Add a cover block.

  2. See the duotone control.

  3. Apply a duotone preset, see no changes.

  4. Pick a color from the placeholder.

  5. See the duotone control.

  6. Apply a duotone preset, see no changes.

Screenshots, screen recording, code snippet

No media, placeholder state, duotone applied:

CleanShot 2023-03-06 at 15 10 02

No media, overlay color, duotone applied:

CleanShot 2023-03-06 at 15 09 33

Environment info

  • WordPress Beta 4
  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Mar 6, 2023
@richtabor richtabor mentioned this issue Mar 6, 2023
Open
@jordesign jordesign mentioned this issue Sep 8, 2023
Closed
43 tasks
jrtashjian added a commit to jrtashjian/gutenberg that referenced this issue Sep 14, 2023
@jrtashjian
Disable duotone until media is provided in Cover block
5fe0683 
Fixes WordPress#48804
@jrtashjian jrtashjian linked a pull request Sep 14, 2023 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable duotone until media is provided in Cover block jrtashjian/gutenberg
1 participant
@richtabor