Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useRootPaddingAwareAlignments is missing from theme.json schema #43624

Closed
mikachan opened this issue Aug 26, 2022 · 0 comments · Fixed by #43628
Closed

useRootPaddingAwareAlignments is missing from theme.json schema #43624

mikachan opened this issue Aug 26, 2022 · 0 comments · Fixed by #43628
Assignees
@t-hamano
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@mikachan
Copy link
Member

Description

The useRootPaddingAwareAlignments key is missing from the theme.json schema. We should include this to maintain a good developer experience when working with theme.json files.

More info about this setting: #42085, #43463

Step-by-step reproduction instructions

  1. Activate a theme with a theme.json file and open the theme.json
  2. Add "useRootPaddingAwareAlignments": true under settings
  3. Notice that the JSON schema is unaware of this key

Screenshots, screen recording, code snippet

image

Environment info

WP 6.0.1, GB trunk, Twenty Twenty-Three

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@mikachan mikachan added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Developer Experience Ideas about improving block and theme developer experience labels Aug 26, 2022
@t-hamano t-hamano mentioned this issue Aug 26, 2022
Merged
@t-hamano t-hamano self-assigned this Aug 26, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 26, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
reid added a commit to AwakeningSV/wordpress that referenced this issue Sep 17, 2022
@reid
Fix navigation close icon alignment.
64d6ec5 
Fix useRootPaddingAwareAlignments by using an updated schema
which has the correct location for this setting.

As of this writing, this blog post does not contain the
correct example code for this setting. The setting must be
inside the settings object and not at the root:
https://make.wordpress.org/themes/2022/09/07/full-width-blocks-and-root-padding-in-wordpress-6-1/

The schema is correct and was fixed here:
WordPress/gutenberg#43624

The navigation block uses this setting to correctly render
the close icon:
WordPress/gutenberg#43576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Theme.json: Fix schema for useRootPaddingAwareAlignments WordPress/gutenberg
3 participants
@mikachan @priethor @t-hamano