Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide means to delete classic menus from within a Block Theme #42601

Closed
getdave opened this issue Jul 21, 2022 · 2 comments
Closed

Provide means to delete classic menus from within a Block Theme #42601

getdave opened this issue Jul 21, 2022 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a

Comments

@getdave
Copy link
Contributor

getdave commented Jul 21, 2022

What problem does this address?

Currently when you are using a Block Theme there is no way to remove an existing Classic Menu. Whilst this might seem like an edge case, it is surprisingly common.

For example, notice how when you have a Classic Menu it will remain in the block's Select Menu dropdown even after you have selected it to be converted into a block menu. Whilst this is intentional, it can be unintuitive. Moreover, once you've decided to commit to using your Block Theme you probably don't want to have you Classic Menus lying around forever more.

What is your proposed solution?

We should provide a means to remove the Classic Menu without having to

  • switch back to a Classic Theme
  • manipulate the database directly, use WPCLI...etc

One idea might be to utilise the Navigation Sidebar. The functionality could/should be afforded a lower priority in the UI, but it should be possible to select from a list of Classic Menus and delete them.

@javierarce Might you be able to consider a visual exploration of how this might work?

@getdave getdave added [Block] Navigation Affects the Navigation Block [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a labels Jul 21, 2022
@getdave
Copy link
Contributor Author

getdave commented Mar 17, 2023

I don't see this as something we should look at. Once #43856 is resolved then much of the confusion here is removed.

If folks want to remove Classic Menus, switching back to a Classic Theme and deleting is a good option. Adding UI into the block editor to manage Classic Menus seems like a step backward.

Closing for now but open to folks disagreeing.

@getdave getdave closed this as completed Mar 17, 2023
@Marc-pi
Copy link

Marc-pi commented Aug 19, 2023

@getdave
yep, i hesitate to switch back to classic theme just to clean my classic menus
what about the custom block theme css ? kept ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a
Projects
None yet
Development

No branches or pull requests

2 participants