-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically utilise classic menu when switching from classic Theme #42600
Comments
Related #42601 |
Noting that this current experience came up as a pain point a few times in the seventeenth call for testing for the FSE Outreach Program:
I've added it as part of the theme switching flows tracking issue as this latest call for testing showed how impactful it would be to resolve. P.S. it's not clear to me necessarily how this relates to this recent merged PR: #44173 It seems like issue is likely broader in scope than that specific use case. |
@annezazu I believe #44173 does partly solve this issue as it will import the most recent classic menu if no block-based menus exist. It does not import based on In the future we might make it import from |
@getdave: Is it possible to make a Gutenberg navigation menu the primary menu, or have slots, similar to what Block part areas do? Currently when I use a block part for the site header I have to manually select the primary menu for the first time, otherwise it shows the last menu that was added. Currently a
This would be much more robust and avoid the need to set the proper primary menu after a block part reset or initial setup:
Related issue comment: #38166 (comment) Edit: Apparently these kinds of "navigation areas" were deprecated: #36524 (comment) |
@strarsis Absolutely. Your request is already on the roadmap for 6.2 🤞 |
The auto import of a Classic Theme has been implemented. Closing. |
What problem does this address?
When switching from a Classic Theme (with a Menu assigned to a Menu Location) to a Block Theme with a Navigation block, the block is currently empty.
This provides a suboptimal UX and could be improved.
What is your proposed solution?
On theme switch, the block should:
primary
Menu Location.wp_navigation
.This should happen without user interaction and should work in the same way across both the Editor and the front of the site.
Note however, that this should be considered part of the auto-assignment mechanic. Therefore, if the block detects that a
wp_navigation
already exists in the database, it should prefer that over converting the classic menu. This is however, likely to be an edge case.The text was updated successfully, but these errors were encountered: