Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Post author name" block not visible on the frontend of a site, on Gutenberg 13.2.0 and higher #41135

Closed
arunsathiya opened this issue May 18, 2022 · 28 comments
Labels
[Block] Post Author Affects the Post Author Block [Type] Bug An existing feature does not function as intended

Comments

@arunsathiya
Copy link
Contributor

Description

"Post author name" block is not visible on the frontend of a site, on Gutenberg 13.2.0 and higher. I can see it fine on Gutenberg 13.1.0 and Gutenberg 13.0.0. Tested with various themes.

Step-by-step reproduction instructions

  • On a site with Gutenberg 13.2.0, add the Post author name block to a page.
  • Optionally, mark that block to link out to the author archive.
  • Publish the page.
  • See that the block is not visible on the live page.

Screenshots, screen recording, code snippet

demo is the author name. Here's how we see it on Gutenberg 13.1.0:

image

And on Gutenberg 13.2.0:

image

Environment info

  • WordPress 5.9.3
  • Gutenberg 13.2.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka
Copy link
Member

Thanks for reporting the issue, @arunsathiya.

I just followed you're reproduction setups, and I can see the "Post Author Name" block on posts/page. Am I missing something?

@Mamaduka Mamaduka added the [Status] Needs More Info Follow-up required in order to be actionable. label May 18, 2022
@arunsathiya
Copy link
Contributor Author

Thanks for testing, @Mamaduka. Is it visible on the frontend of the post/page for you? It's available on the backend/Gutenberg editor as expected, but it's missing on the frontend after publishing the post/page.

@Mamaduka
Copy link
Member

Is it visible on the frontend of the post/page for you?

Correct. Here's the recording:

CleanShot.2022-05-18.at.16.40.17.mp4

@arunsathiya
Copy link
Contributor Author

That's interesting. 🤔 Here's what I see on a site with WordPress 5.9.3 with Gutenberg 13.1.0 (initially) and Gutenberg 13.2.1 (latest version). We can spot that the block is visible while on Gutenberg 13.1.0 but is missing on update to Gutenberg 13.2.0 or higher.

Screen.Recording.2022-05-18.at.6.23.27.PM.mov

@chad1008
Copy link
Contributor

I'm also not able to reproduce this. The author block renders on the front end for me regardless of what version I have installed.

This feels very similar to

In both cases, something related to rendering posts, or parts of a post are working fine in the editor, but not rendering on the front end, and aren't able to be reproduced consistently.

Could be coincidence, but I wonder if there's a trigger somewhere.

@annezazu
Copy link
Contributor

cc @tinjure20 perhaps this does match the issue you reported :)

@tinjure20
Copy link

cc @annezazu, indeed it does!

@andrewstaffell
Copy link

Also having this issue (as well as the query loop taxonomy filters).

@tinjure20
Copy link

In my further testing, Post Author block is displayed correctly both on the editor and front end. I am still having problem displaying Post Author name block on the front end. See screenshots below:

Editor (post author name is displayed):
author-name-block-1

Front end (post author name is empty):
author-name-block-2

@alyssabhogan
Copy link

@tinjure20 Yes, that is true. I originally reported this bug on the WordPress.com forums which (I believe) led to this Gutenberg issue report. The "Post Author" block, with avatar and byline blank, would otherwise be a somewhat suitable work-around for the task of displaying an author's name, except that it doesn't support the "isLink" attribute that the "Post Author Name" block has. This, in effect, leaves no way for sites using only the site editor/FSE (ie: wp.com) to link to an author's archive.

@Mamaduka
Copy link
Member

I was able to reproduce the issue on my different installation.

#41122 should fix the bug. Props to @dd32.

@annezazu, @chad1008, do you think we should do a minor release that includes this fix?

@andrewstaffell
Copy link

andrewstaffell commented May 19, 2022 via email

@Mamaduka
Copy link
Member

Hi, @andrewstaffell

Just tested #41067 and it's fixed as well 🎉

@andrewstaffell
Copy link

andrewstaffell commented May 19, 2022 via email

@alyssabhogan
Copy link

Thank you all!

@chad1008
Copy link
Contributor

That's awesome, thanks @Mamaduka! I agree, a minor release sounds like a good idea :)

@annezazu
Copy link
Contributor

I think a minor sounds like a good idea (assuming you are talking about a minor GB release in this case). I'm concerned this is happening in RC4 as well based on the previous info that @tinjure20 shared #24952 (comment) Going to add this to the 6.0 minor release milestone as a result.

@annezazu annezazu added [Type] Bug An existing feature does not function as intended Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release and removed [Status] Needs More Info Follow-up required in order to be actionable. labels May 19, 2022
@Mamaduka
Copy link
Member

The Gutenberg 13.2.2 was released last night. Props to @chad1008.

@annezazu, there's no need to backport the changes into WP. It was only a bug in the Gutenberg plugin.

Repository owner moved this from Triage to Done in WordPress 6.0.x Editor Tasks May 20, 2022
@Mamaduka Mamaduka removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label May 20, 2022
@andrewstaffell
Copy link

@Mamaduka @annezazu just for clarification – is Post Author Name supposed to be available in WordPress 6.0?

@Mamaduka
Copy link
Member

@andrewstaffell, Post Author Name block should be available in WordPress 6.0.

@andrewstaffell
Copy link

Thank you @Mamaduka for the swift response. That’s what I thought too – it’s been in Gutenberg for ages, and I thought that I had seen that it was going to be in an even earlier release of core – but it seems to be missing from the latest RC.

What’s the best way to check / who’s the best person to ask if this is a simple oversight that can be sorted for the release?

The normal Post Author block doesn’t offer the option to link to the author page so it feels quite important to me that this is released!

@andrewstaffell
Copy link

andrewstaffell commented May 20, 2022

Screenshot of 6.0 RC3 files... Post Author Biography is included but Post Author Name is missing. Surely a mistake?!

Screenshot 2022-05-20 at 09 55 52

@Mamaduka
Copy link
Member

@andrewstaffell, that's odd. Based on the Gutenberg version, the block was introduced, it should be included in 6.0.

Unless it was excluded for some specific reason. @annezazu might have more details.

@andrewstaffell
Copy link

andrewstaffell commented May 20, 2022

Yes, exactly, the versioning suggests it should be there too. Some oversight or glitch in the build? Any chance of resolving, @annezazu? Thanks both!

@annezazu
Copy link
Contributor

Hey all! Check out this convo here about this exact problem/situation:

#24952 (comment)

The normal Post Author block doesn’t offer the option to link to the author page so it feels quite important to me that this is released!

You'll see a comment from yours truly there advocating the same as well as context for why the call was made.

@andrewstaffell
Copy link

andrewstaffell commented May 21, 2022

@annezazu thanks! I had read that thread, but unless I’m missing or misinterpreting something, there’s no actual explanation of why it’s been omitted, just observation of that fact. Even from the quote from @adamziel.

Considering that Post Author Biography has made it in, are we sure this isn’t just a simple oversight? As @Mamaduka said, the versioning suggests it should be there.

Who would be the authority on this? Is it possible to double check it ahead of the 6.0 release?

If there is a technical reason for it, fair enough, but I’m yet to find/read one!

@annezazu
Copy link
Contributor

I do not have any additional information other than what was in the thread. From my vantage point, this was not included due to lack of a plan forward for blocks that overlap with each other and the fact that these are still seen as experimental (some blocks can exist in the plugin and still not get merged into Core): #24952 (comment)

Who would be the authority on this? Is it possible to double check it ahead of the 6.0 release?

This was double checked ahead of the release (that's the convo you see there)! I'll cc @priethor (the other co-release coordinator for 6.0) but, at this point, this was a known decision early on in the release cycle and new features, including new blocks cannot be added in at this stage.

@andrewstaffell
Copy link

OK! Understood. Thanks for the extra clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Author Affects the Post Author Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants