Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Component: No color contrast warning for link color against background color #38222

Closed
annezazu opened this issue Jan 25, 2022 · 4 comments
Labels
[Feature] Component System WordPress component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

Currently, in 5.9 there is not a color warning for the link color when compared against the background color. There is one in place for text color against background color and the same needs to exists for link color.

Step-by-step reproduction instructions

  1. Add a paragraph block/write some text.
  2. Make the background black in block settings.
  3. Make link color black.
  4. See no accessibility warning.
  5. Make text color black, see accessibility warning.

Screenshots, screen recording, code snippet

color.contrast.mov

Environment info

  • WordPress 5.9
  • No Gutenberg
  • TT2
  • Chrome
  • MacOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Feature] Component System WordPress component system [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Jan 25, 2022
@ramonjd
Copy link
Member

ramonjd commented Feb 8, 2022

I think the merged PR #38100 might close this one too? Reported previously in #24595

@annezazu
Copy link
Contributor Author

annezazu commented Feb 8, 2022

Sadly, no. I just tested with 5.9 and GB 12.5.3. Still no warning 😢

@ramonjd
Copy link
Member

ramonjd commented Feb 8, 2022

Sadly, no. I just tested with 5.9 and GB 12.5.3. Still no warning 😢

Ah okay, the PR was merged today so it should be available on the next Gutenberg release.

@annezazu
Copy link
Contributor Author

annezazu commented Mar 7, 2022

Seems fixed!

Screen Shot 2022-03-07 at 3 08 35 PM

@annezazu annezazu closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants