Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ContrastChecker with link-color support #24595

Closed
aristath opened this issue Aug 17, 2020 · 0 comments · Fixed by #38100
Closed

Extend ContrastChecker with link-color support #24595

aristath opened this issue Aug 17, 2020 · 0 comments · Fixed by #38100
Assignees
@ramonjd
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@aristath
Copy link
Member

Came up in #24513 (comment)

Currently ContrastChecker only checks for contrast between background-color and text-color.
With the introduction of link-color controls, we'll need to extend that functionality to link-colors as well.
Links however can be a little more complicated than normal text... Links should have sufficient contrast with the background color - just like normal text, but at the same time, they should have a minimum of 3:1 contrast with surrounding text.

See this article on WCAG and link-colors for more details on what the rules are for links.
@aristath aristath mentioned this issue Sep 2, 2020
Closed
@skorasaurus skorasaurus mentioned this issue Jan 20, 2022
Merged
8 tasks
@ramonjd ramonjd moved this to ⏱ Not Started in Design Tools Project Jan 25, 2022
@ramonjd ramonjd moved this from ⏱ Not Started to ⏳ In Progress in Design Tools Project Jan 25, 2022
@ramonjd ramonjd self-assigned this Jan 25, 2022
Repository owner moved this from ⏳ In Progress to ✅ Done in Design Tools Project Feb 7, 2022
@ramonjd ramonjd mentioned this issue Feb 8, 2022
Closed
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Color Contrast labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramonjd ramonjd

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
Design Tools Project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Contrast Checker: check link color WordPress/gutenberg
4 participants
@aristath @ramonjd @jorgefilipecosta @priethor