Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle merging of URL Details REST API endpoint into Core for WP 5.9 #35756

Closed
getdave opened this issue Oct 19, 2021 · 5 comments
Closed

Handle merging of URL Details REST API endpoint into Core for WP 5.9 #35756

getdave opened this issue Oct 19, 2021 · 5 comments
Assignees
Labels
Core REST API Task Task for Core REST API efforts

Comments

@getdave
Copy link
Contributor

getdave commented Oct 19, 2021

Rich URL previews were introduced for the Link UI in Gutenberg Plugin version 10.9.0. This work is now due to be merged into Core for the upcoming WP 5.9 release.

Therefore we need to ensure the supporting infrastructure is also merged into Core. This is mainly the URL Details REST API controller that was introduced in #18042.

@hellofromtonya would you be available to pair with me on this one?


Left a comment about permission handling, after that I'm fine with this merging into GB.

Is this supposed to land in 5.5? or Is it required for a feature that will land in WP 5.5? If it's supposed to be 5.5, a Core ticket might be needed.

Yep a trac ticket would be needed for this.

Originally posted by @TimothyBJacobs in #18042 (comment)

@getdave getdave added the Core REST API Task Task for Core REST API efforts label Oct 19, 2021
@TimothyBJacobs
Copy link
Member

@getdave Let's make sure to stabilize the namespace first. I think this should go in wp-block-editor/v1 to match the block editor settings route.

@hellofromtonya
Copy link
Contributor

@hellofromtonya would you be available to pair with me on this one?

Sure @getdave. Once the namespace is stabilized (see Timothy's comment above) and he's 👍 with it, then it needs a Trac ticket and patch for commit (I can help with all of these).

@getdave
Copy link
Contributor Author

getdave commented Oct 25, 2021

@getdave Let's make sure to stabilize the namespace first. I think this should go in wp-block-editor/v1 to match the block editor settings route.

@TimothyBJacobs @hellofromtonya Ready for review here #35915

@skorasaurus
Copy link
Member

@getdave is this still applicable/valid ?

@getdave
Copy link
Contributor Author

getdave commented May 10, 2023

I believe this is in core already

@getdave getdave closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core REST API Task Task for Core REST API efforts
Projects
None yet
Development

No branches or pull requests

4 participants