Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short blocks have very small hover area. #3355

Closed
markjaquith opened this issue Nov 6, 2017 · 3 comments
Closed

Short blocks have very small hover area. #3355

markjaquith opened this issue Nov 6, 2017 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback.

Comments

@markjaquith
Copy link
Member

Single-line paragraphs (and probably other short blocks) have a very small hover area. For a paragraph, it is literally limited to the line-height of the text. The padding around the item doesn't count. This makes working with one-line paragraphs rather frustrating.

twitchy-single-line-paragraph

@markjaquith markjaquith added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Blocks Overall functionality of blocks labels Nov 6, 2017
@aduth
Copy link
Member

aduth commented Nov 6, 2017

Part of the issue here is that the "Between Inserter" creates a padded buffer zone when it activates, and for short paragraphs it is easy to accidentally move between buffer zones of the before and after inserters when trying to access the text itself.

See Implementation Notes of #3008 for demonstration.

It could be that this buffer zone needs to be adjusted, either globally or based on block height; the latter may resolve these specific cases, but also introduces an inconsistent experience.

@youknowriad
Copy link
Contributor

It could be that this buffer zone needs to be adjusted, either globally or based on block height; the latter may resolve these specific cases, but also introduces an inconsistent experience

I wonder if there's a way to do this:

  • Keep the buffer as is
  • Hovering the buffer shows the inserter
  • Clicking the buffer, clicks on the block

@aduth
Copy link
Member

aduth commented Nov 6, 2017

I could see that working well, but would be a challenge to implement. The obvious solution would be to apply pointer-events: none; to the buffer area (to allow the natural cursor, e.g. text to take effect), but of course this means that the mouse events would not fire consistently (to hide).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

4 participants