Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo Block doesn't load after previously uploading #32171

Closed
annezazu opened this issue May 24, 2021 · 3 comments · Fixed by #32229
Closed

Site Logo Block doesn't load after previously uploading #32171

annezazu opened this issue May 24, 2021 · 3 comments · Fixed by #32229
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@annezazu
Copy link
Contributor

Description

With Gutenberg Version 10.7.0-rc.1, the Site Logo block now just shows as infinitely loading without an option to replace the image in the block toolbar. This is a regression from 10.6.2.

Step-by-step reproduction instructions

  1. Use Gutenberg 10.6.2 and set a site logo in the Site Logo Block
  2. Switch to Gutenberg Version 10.7.0-rc.1 and view where you previously added the Site Logo Block to see error.

Expected behaviour

Should be able to see the previous site logo that was uploaded and have the option to replace it.

Actual behaviour

The Site Logo Block doesn't show an option to replace it and continually shows as loading.

Screenshots or screen recording (optional)

site.logo.block.loading.mov

WordPress information

  • WordPress version: 5.7.2
  • Gutenberg version: Version 10.7.0-rc.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1 Blocks

Device information

  • Device: Desktop
  • Operating system: MacOS
  • Browser: Chrome
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Block] Site Logo Affects the Site Logo Block labels May 24, 2021
@Mamaduka
Copy link
Member

I think #32092 should also fix this issue.

I see a spinner in trunk, but when I switch to branch from the PR, Site Logo Block works as expected.

@colorful-tones
Copy link
Member

colorful-tones commented May 26, 2021

I just found this same issue. However, I would like to add that this Issue's title: Site Logo Block doesn't load after previously uploading is not entirely suitable. As I've noticed that it happens in TwentyTwentyOne, with Gutenberg 10.7.1, and when just inserting a new Site Logo block in any Page/Post.

However, if we're referring to doesn't load after previously uploading as in the Site Logo should always show the previous attached logo, regardless of where/when a new Site Logo block is placed. Then the title is likely suitable.

Gif of issue in TwentyTwentyOne and Gutenberg 10.7.1
Gutenberg-10 7 1-Site-Logo-block-bug_TwentyTwentyOne

@colorful-tones
Copy link
Member

It looks like @aristath has #32229 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants