Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor UX after removing gutenberg_add_edit_link_for_post_type filter #3158

Closed
iandunn opened this issue Oct 25, 2017 · 4 comments
Closed

Poor UX after removing gutenberg_add_edit_link_for_post_type filter #3158

iandunn opened this issue Oct 25, 2017 · 4 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@iandunn
Copy link
Member

iandunn commented Oct 25, 2017

bdf94e6 removed the gutenberg_add_edit_link_for_post_type filter, which was added in 6884717 for #2750.

I think that filter -- or something comparable -- is necessary in order for some sites to test the plugin, because Gutenberg's support for meta boxes is still very limited, and many CPTs rely heavily on them.

If sites cannot choose to make the classic editor the default for those post types, then users have to manually choose the classic editor, which leads to confusion and annoyance. It may not sound like a big deal, but in less than 24 hours after upgrading to 1.5.0, I received 5 complaints from users, on a site that only has a couple dozen daily active users to begin with.

@iandunn iandunn added the [Type] Bug An existing feature does not function as intended label Oct 25, 2017
@aaronjorbin
Copy link
Member

This was discussed a bit during today's dev chat with the decision that there needs to be a filter to turn things off on a per post type basis. It may not be included in the code as a part of the merge proposal though, and may instead live in a separate "turn Gutenberg off" plugin then.

@iandunn
Copy link
Member Author

iandunn commented Oct 26, 2017

👍

I'm not too worried about being able to turn Gutenberg off after the merge, I imagine that it will have much better support for CPTs by then. I think that filter is most useful right now, for sites that want to help test it, but need their CPTs to continue working.

In the meantime, I've had to downgrade to 1.4, and this is a blocker for me installing any future updates.

@iandunn
Copy link
Member Author

iandunn commented Oct 26, 2017

#3146 has a gutenberg_can_edit_post_type filter now, which would solve this.

@iandunn
Copy link
Member Author

iandunn commented Oct 26, 2017

#3146 is merged now :)

@iandunn iandunn closed this as completed Oct 26, 2017
svn2github pushed a commit to svn2github/wordcamp-mu-plugins that referenced this issue Oct 26, 2017
The previous filter was removed in 1.5, and the new one was added in 1.5.2.

See WordPress/gutenberg#3158

git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins@6056 74240141-8908-4e6f-9713-ba540dce6ec7
iandunn pushed a commit to WordPress/wordcamp.org that referenced this issue Nov 15, 2018
The previous filter was removed in 1.5, and the new one was added in 1.5.2.

See WordPress/gutenberg#3158

git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@6056 74240141-8908-4e6f-9713-ba540dce6ec7
vedanshujain pushed a commit to WordPress/wordcamp.org that referenced this issue Nov 29, 2018
The previous filter was removed in 1.5, and the new one was added in 1.5.2.

See WordPress/gutenberg#3158

git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@6056 74240141-8908-4e6f-9713-ba540dce6ec7


git-svn-id: https://github.com/WordPress/wordcamp.org.git@1046 a64dc54a-4538-25e2-d9ce-ce57b7db7bff
vedanshujain pushed a commit to WordPress/wordcamp.org that referenced this issue Nov 29, 2018
The previous filter was removed in 1.5, and the new one was added in 1.5.2.

See WordPress/gutenberg#3158

git-svn-id: http://meta.svn.wordpress.org/sites/trunk/wordcamp.org@6056 74240141-8908-4e6f-9713-ba540dce6ec7
vedanshujain pushed a commit to WordPress/wordcamp.org that referenced this issue Dec 6, 2018
The previous filter was removed in 1.5, and the new one was added in 1.5.2.

See WordPress/gutenberg#3158

git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@6056 74240141-8908-4e6f-9713-ba540dce6ec7
vedanshujain pushed a commit to WordPress/wordcamp.org that referenced this issue Dec 6, 2018
The previous filter was removed in 1.5, and the new one was added in 1.5.2.

See WordPress/gutenberg#3158

git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@6056 74240141-8908-4e6f-9713-ba540dce6ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants