Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block: Changing the orientation isn't straightforward #29441

Closed
david-szabo97 opened this issue Mar 1, 2021 · 5 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@david-szabo97
Copy link
Member

Navigation block doesn't have any visible options to change between vertical and horizontal orientation. The only way is to use "Transform to variation" which is unfriendly for beginner users.

We should add an option to the block's toolbar or to the inspector.

image

@david-szabo97 david-szabo97 added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Mar 1, 2021
@david-szabo97 david-szabo97 changed the title Navigation block: Allow changing orientation Navigation block: Changing the orientation isn't straightforward Mar 1, 2021
@mtias mtias added [Feature] Block Variations Block variations, including introducing new variations and variations as a feature Needs Design Feedback Needs general design feedback. labels Mar 2, 2021
@jasmussen
Copy link
Contributor

I know we intentionally kept it separate from the block switcher. But here's how that might look like:

transform

@eduardozulian
Copy link

@jasmussen do you know if there is a particular reason why we ended up with two separate blocks (horizontal and vertical) rather than a setting on a broader Navigation Block? I think it might work if we turn the "Transform to variation" option into a setting under "Display".

Thank you!

@jasmussen
Copy link
Contributor

do you know if there is a particular reason why we ended up with two separate blocks (horizontal and vertical) rather than a setting on a broader Navigation Block?

I know the key bit here is to ensure that the mover control points in the right direction based on context, so primarily a technical consideration. @ntsekouras please correct any bits I might be missing here.

I think it might work if we turn the "Transform to variation" option into a setting under "Display".

Keeping in mind that more blocks than Navigation (currently Buttons) are likely going to need a user-friendly interface for changing orientation, it's important we think in terms of an interface that will work for any block. Also specifically for Navigation, as additional design tools (padding, margin, more color options, overlay menus, #30370) become available, we remain careful with relying on the inspector as the primary interface for transforms.

@ntsekouras
Copy link
Contributor

I know the key bit here is to ensure that the mover control points in the right direction based on context, so primarily a technical consideration. @ntsekouras please correct any bits I might be missing here.

That's true but this was the first exploration about block variations transforms and I totally agree with Joen's comment:

Keeping in mind that more blocks than Navigation (currently Buttons) are likely going to need a user-friendly interface for changing orientation, it's important we think in terms of an interface that will work for any block.

@annezazu
Copy link
Contributor

annezazu commented Aug 3, 2023

Closing this out as this is the current experience in 6.3 RC3 :)

Screen Shot 2023-08-03 at 12 24 49 PM

@annezazu annezazu closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants