-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Block: Sidebar/Inspector control improvements & allow always-collapsed menu #30370
Comments
Everything here seems super great, except for the mobile menu preview thing; I don't quite understand it's purpose, and with the design shown it's not obvious what it actually is/does. |
Absolutely. The "feature card" at the top is something I think will either start to make sense in a PR, and take shape as part of that, or reveal itself to not work in practice. It is inspired by some of the Global Styles patterns and aims to elevate the sidebar from being a dull sequence of form widgets to adding some character to each block. |
Where are we with this one now that the component is ready? |
There are some fresher mockups for this one here: #18395 (comment) |
Changed this one to an overview issue, where #34783 exists as a separate ticket. I'd love to pair on that one. |
The recent #35568 PR actually accomplished most of what's on this list. Except for this one:
This item was added to embrace one of the patterns being explored for Global Styles in #34574, but is arguably best tracked separately, as it is a pattern that can/should be applied to all blocks, not just navigation. In that vein, I'm going to close this one, and follow up with a separate ticket once those pieces come into more clarity. |
Another thing we don't have is the "preview". Also using it in practice I think we can add more contextual info for each state. (As in, update the help description based on what option is set to better communicate what is going on.) |
What problem does this address?
The inspector controls for the navigation block have grown organically and is deviating from proposals in #27331 and #27473 (comment) in a few ways.
Additionally, with improvements ticketed in the following issues, it will be necessary to add some new controls:
This ticket serves to provide a path forward for the design of the navigation sidebar.
What is your proposed solution?
A few things here, but note that each of these can happen as separate steps, and should be looked at holistically in context of #27473 and #27331:
"Unfold nested submenus"
Part of this mockup is also a new toggle in the submenu category, to let you unfold nested submenus. That is, instead of having to expand out in ever expanding menus like this:
... nested submenus would expand like this:
The text was updated successfully, but these errors were encountered: