Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] @wordpress/data-core Wrong return type #29260

Closed
cpiber opened this issue Feb 23, 2021 · 0 comments · Fixed by #30639
Closed

[Documentation] @wordpress/data-core Wrong return type #29260

cpiber opened this issue Feb 23, 2021 · 0 comments · Fixed by #30639
Assignees
@mkaz
Labels
[Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers

Comments

@cpiber
Copy link
Contributor

cpiber commented Feb 23, 2021

gutenberg/packages/core-data/src/selectors.js

Line 114 in f480b49

* @return {boolean} Whether the entities are loaded
says getEntitiesByKind returns a {boolean} when it really returns a {Object|null}, the array of entities.
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Feb 23, 2021
mkaz added a commit that referenced this issue Apr 8, 2021
@mkaz
Fixes return type for getEntitiesByKind
21bda1e 
The return type was specified as boolean, but the data is being passed to
the lodash filter function and returning its result which will be an
Array<Object> not a boolean.

Closes #29260
@mkaz mkaz mentioned this issue Apr 8, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 8, 2021
ntsekouras pushed a commit that referenced this issue Apr 9, 2021
@mkaz
Fixes return type for getEntitiesByKind (#30639)
2aefc5b 
The return type was specified as boolean, but the data is being passed to
the lodash filter function and returning its result which will be an
Array<Object> not a boolean.

Closes #29260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaz mkaz

Labels
[Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes return type for getEntitiesByKind WordPress/gutenberg
3 participants
@mkaz @skorasaurus @cpiber