Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Block: Make Focus Settings Image-Specific #28859

Closed
ianstewart opened this issue Feb 8, 2021 · 3 comments · Fixed by #42859
Closed

Cover Block: Make Focus Settings Image-Specific #28859

ianstewart opened this issue Feb 8, 2021 · 3 comments · Fixed by #42859
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@ianstewart
Copy link
Contributor

ianstewart commented Feb 8, 2021 •
edited
Loading

What problem does this address?

Focus settings for background images are not currently image-specific. When creating patterns that use focus settings in a background image the "cropping" of an image may appear confusing to users who have not yet encountered this block setting.

2021-02-08 14 45 55

What is your proposed solution?

It may make sense to make focus settings specific to an image and reset to a neutral position when a new image is uploaded. This appears to already be what happens when one removes media from a cover block and then re-adds media.
@talldan talldan added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Feb 9, 2021
@Quintis1212
Copy link
Contributor

Hello ) I think I can implement this enhancement ) see you soon here )

@Quintis1212 Quintis1212 mentioned this issue Feb 22, 2021
Closed
@Quintis1212
Copy link
Contributor

Hello ) I make enhancement for this issue ) checkout it here - #29231

paulopmt1 added a commit to paulopmt1/gutenberg that referenced this issue Aug 1, 2022
@paulopmt1
Reset focalPoint after replacing the cover image WordPress#28859
88dd14d
@paulopmt1 paulopmt1 mentioned this issue Aug 1, 2022
Merged
Mamaduka pushed a commit that referenced this issue Aug 10, 2022
@paulopmt1
Reset focalPoint after replacing the cover image #28859 (#42859)
c3f19c4
@paulopmt1
Copy link
Contributor

Thank you for reviewing and merging it, @stokesman and @Mamaduka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset focalPoint after replacing the cover image paulopmt1/gutenberg
4 participants
@ianstewart @talldan @paulopmt1 @Quintis1212