Social block icons misshapen when used in navigation block

[talldan]

Description

When adding a social icon in a navigation block, the icons are oblong instead of circles.

Step-by-step reproduction instructions

1. Add a navigation block.
2. Start with an empty nav block
3. Add a Social block within the nav block
4. Add some social icons

Expected behaviour

The icons appear as circles, like they do when the block is used outside of navigation

Actual behaviour

The icons are oblong

Screenshots or screen recording (optional)

WordPress information

• WordPress version: 5.6
• Gutenberg version: 9.8rc1 (on the master branch)
• Are all plugins except Gutenberg deactivated? Y
• Are you using a default theme (e.g. Twenty Twenty-One)? Y (2021)

Device information

• Device: Desktop
• Operating system: Mac OS
• Browser: Brave

[Arash-11]

Hey! I'm a newbie to open source but I'm going to take a stab at this issue.

[talldan]

That'd be great, thanks @Arash-11. Let us know if you need any assistance along the way.

[Arash-11]

Thanks a lot @talldan, I'll definitely let you know.

[Arash-11]

Hi @talldan. I apologize for the newbie question but I was wondering how long it usually takes for a pull request to get reviewed/merged? I'm just curious as this is my first main contribution :)

[jasmussen]

Hi @Arash-11, thank you for your work. From looking at https://github.com/Arash-11/gutenberg/commit/d6b39014ec6bb4b8d3fafa886ea77bb393feb78e, the code seems like it might work, though I'd like to test it a bit more deeply. Have you made it into a pull request, though? I wasn't immediately able to find a pull request attached to your commit. That would make it easier to test. Thank you.

[Arash-11]

Hi @jasmussen, I am happy to have been able to work on it. I did do a pull request: #28448 (comment)

But I might have done it wrong then, I didn't do a PR on my forked copy but on the original repo. Please let me know if I did this incorrectly.

[Arash-11]

I apologize, looks like I missed the following step and did it wrong.

Step 7: Go to your forked repository on GitHub -- it will automatically detect the change and give you a link to create a pull request.

Should I do a pull request now, in my own forked copy?

[jasmussen]

Should I do a pull request now, in my own forked copy?

Yes, exactly! That will allow me to check out your fork, and compile the pull request to test it. Thank you!

[Arash-11]

Got you! I did a new pull request: https://github.com/Arash-11/gutenberg/pull/1#issue-565160695. Thank you so much for the help!

[talldan]

@Arash-11 Sorry for missing your pull request. Looks like you followed the right process when you made the PR #28448. It can sometimes take a little while for code to be reviewed, and other times it happens quickly.

To help link the issue and the PR together, it's good to write 'Fixes #28340' in the PR description instead of the title. Github automatically then links the issue and the PR together (https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue).

[Arash-11]

@talldan No worries. Good to know I followed the correct process, and thanks for the information about the code review process.

Also, thanks for letting me know about how linking the issue and the PR works in GitHub - I didn't know this.

[jasmussen]

I reviewed your PR, thanks again! Take a look, let me know how I can help.

[Arash-11]

Thank you for reviewing my PR!