-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets screen: Use button block appender instead of inline appender #26072
Comments
@mapk: Could we go back to the block appender? (The one that the Columns block uses.) |
I'd like to keep the experience as close to the Post Editor as possible. Creating an empty post (no content, just a title) does not leave any empty Paragraph blocks anywhere that I noticed. So why does that happen in the Widget Editor? |
@mapk - I actually have seen this happen pretty extensively in the Post editor, but I'd agree that anywhere blocks are used should be a consistent experience. Somehow this feels more impactful in widgets than in post content because of the way themes work with widgets for styling, and sometimes even whether or not the widget area loads at all. |
I'm surprised. I just tested this with a title and can see the prompt to start writing in the post editor, but when I preview on frontend, I'm not seeing any empty paragraphs. So weird. In either case though, as you mentioned @DaisyOlsen, if we can get this fixed in one editor, it should be implemented on all of them. :) |
Paragraphs aren't there by default, but it's very easy to create them, as soon as you click into the appender it becomes a paragraph block. I think this consistent across editors, but it's difficult for users because an empty paragraph and an appender look exactly the same. |
So it seems to me this is a technical issue? Should we just not render empty Paragraph blocks at all? |
I think it's only a technical issue if it wasn't intended to work like that in the first place. We'd probably need to consult someone that's been involved in Gutenberg from the start to understand how it should work (as it predates my involvement). Maybe @mtias or @jasmussen might know. |
In most content areas an empty paragraph shouldn't be the end of the world, though #10051 would be nice to address to make that feel less jarring than it currently feels. An alternative solution that may be more widget-like, is to change the default appender from being the empty paragraph, to being the white plus button, as is seen in the Group block if inserted on its own: Then you have to select the Paragraph as a block, to explicitly insert it. |
Adding in this associated issue: |
This was considered early on, but design and a11y feedback suggested against this solution. So I pursued to align it more consistently with the post editor. It does introduce this hanging Paragraph now which is far from ideal. I wouldn't mind returning back to the larger |
I brought up the issue during a Design Feedback session. @garretthyder and myself were present. |
Describe the bug
It is very easy to have an empty Paragraph block end up in an otherwise empty widget area.
To reproduce
Steps to reproduce the behavior:
Expected behavior
It should be less easy to have an empty block in a widget area. Some themes will check for contents in a widget area as a mechanism to determine whether or not to output the wrapper HTML. Others will have styling that will create a visibly empty container.
Editor version (please complete the following information):
Additional context
Also worth noting that I've seen cases where adding an empty widget as a workaround to avoid default widget content without displaying any actual content. Having an empty column in a multi-column footer, for example. Not really a good practice but it does happen.
The text was updated successfully, but these errors were encountered: