Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets screen: style adjustments for the block areas hover and font face #25777

Closed
afercia opened this issue Oct 1, 2020 · 1 comment
Closed
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Oct 1, 2020

Describe the bug
Not sure whether this has been already reported. In the new widgets screen I see a couple of style inconsistencies:

The block areas accordion headers get a grey background on hover, which is not that nice to see against a grey background and should probably be changed:

Screenshot 2020-09-30 at 14 56 29

The accordion titles and also the content within the block areas (e.g. the placeholder text "Start writing...") use a serif typeface:

Screenshot 2020-10-01 at 16 20 32

The serif typeface is also applied to the actual content entered in a block areas:

Screenshot 2020-10-01 at 16 34 32

Note: my active theme is Twenty Twenty, which uses a sans-serif typeface so the Widgets preview is also non-WYSIWYG

To my knowledge, WordPress doesn't use serif typefaces in its user interface anywhere. Seems to me this style is inehrited from the editor styles wrapper which uses the scss variable $editor-font: "Noto Serif", serif;. this shoul dprobbly be changed, as it sets a serif typeface on all the elements in the page.

Ideally, the parts of the Widgets screen that are user interface should use the WordPress "system font stack". Instead, to be truly WYSIWYG, the content within the block areas should use the font used by the theme.

To reproduce

  • I tested it on latest master 16e98d4 but I guess it's the same on the latest plugin version 9.1.0
  • go to Appearance > Widgets
  • see the hover and typeface styles
@afercia afercia added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 1, 2020
@draganescu draganescu added Needs Design Needs design efforts. Needs Design Feedback Needs general design feedback. labels Oct 16, 2020
@mapk
Copy link
Contributor

mapk commented Oct 20, 2020

It looks like the UI has been cleaned up with other PRs. Tested on Twenty Twenty.

ui

  • No more serif fonts in the Heading.
  • Hover affect has been removed, but kept the highlighting for the focus state.

@mapk mapk closed this as completed Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants