Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg shows private taxonomies in Categories & Tags #2450

Closed
hedgefield opened this issue Aug 17, 2017 · 5 comments
Closed

Gutenberg shows private taxonomies in Categories & Tags #2450

hedgefield opened this issue Aug 17, 2017 · 5 comments
Assignees
@danielbachhuber @BE-Webdesign
Labels
Core REST API Task Task for Core REST API efforts [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Milestone
Merge: REST API

Comments

@hedgefield
Copy link

It shouldn't. ;)

window

Prominent Words is a private taxonomy that our plugin creates and fills automatically through analysis of the content. The user being able to edit this is not intended behaviour.
@youknowriad
Copy link
Contributor

Tried to address this but it seems that there's no way to retrieve the public flag with the REST API :(

@youknowriad youknowriad added Core REST API Task Task for Core REST API efforts [Type] Bug An existing feature does not function as intended labels Aug 17, 2017
@BE-Webdesign BE-Webdesign self-assigned this Sep 3, 2017
@BE-Webdesign BE-Webdesign mentioned this issue Sep 4, 2017
Merged
BE-Webdesign added a commit that referenced this issue Sep 4, 2017
@BE-Webdesign
Filters out private taxonomies from sidebar UI.
ba51d81 
Fixes #2450,

Could potentially break if the user does not have privileges to see the
edit context. Will need to test more.
BE-Webdesign added a commit that referenced this issue Sep 25, 2017
@BE-Webdesign
Filters out private taxonomies from sidebar UI.
91c33be 
Fixes #2450,

Adds a public property to the taxonomy field, this is used to determine
whether the taxonomy is public or private. Private taxonomies will now
properly be hidden. Does not work 100% properly for Authors, this is a larger problem with
REST API.
@youknowriad youknowriad mentioned this issue Dec 20, 2017
Closed
2 tasks
@youknowriad
Copy link
Contributor

Same issue regarding the show_ui flag. Not available in the REST API yet.

@benoitchantre benoitchantre mentioned this issue Jan 19, 2018
Closed
@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@johnbillion
Copy link
Member

Ref: https://core.trac.wordpress.org/ticket/42707

@johnbillion johnbillion added [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. and removed [Type] Bug An existing feature does not function as intended labels Feb 13, 2018
schlessera pushed a commit that referenced this issue Mar 6, 2018
@BE-Webdesign @schlessera
Filters out private taxonomies from sidebar UI.
c6bd6dc 
Fixes #2450,

Adds a public property to the taxonomy field, this is used to determine
whether the taxonomy is public or private. Private taxonomies will now
properly be hidden. Does not work 100% properly for Authors, this is a larger problem with
REST API.
@mtias mtias modified the milestones: Merge Proposal, Core API Mar 7, 2018
@danielbachhuber
Copy link
Member

@WordPress/gutenberg-core Is it worthwhile to shim the visbility in to address the issue for WordPress 4.9.x ?

@pento
Copy link
Member

pento commented Apr 11, 2018

Yup, this should done shimmed in.

@danielbachhuber danielbachhuber self-assigned this Apr 11, 2018
danielbachhuber pushed a commit that referenced this issue Apr 13, 2018
@BE-Webdesign @danielbachhuber
Filters out private taxonomies from sidebar UI.
d50111a 
Fixes #2450,

Adds a public property to the taxonomy field, this is used to determine
whether the taxonomy is public or private. Private taxonomies will now
properly be hidden. Does not work 100% properly for Authors, this is a larger problem with
REST API.
danielbachhuber pushed a commit that referenced this issue Apr 13, 2018
@BE-Webdesign @danielbachhuber
Filters out private taxonomies from sidebar UI. (#2654)
0c5aa0d 
* Filters out private taxonomies from sidebar UI.

Fixes #2450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbachhuber danielbachhuber

@BE-Webdesign BE-Webdesign

Labels
Core REST API Task Task for Core REST API efforts [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Milestone
Merge: REST API
Development

No branches or pull requests
8 participants
@danielbachhuber @johnbillion @karmatosed @youknowriad @pento @mtias @hedgefield @BE-Webdesign