Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the "Advanced" cog should set focus on the block tab #2304

Closed
jasmussen opened this issue Aug 9, 2017 · 2 comments
Closed

Clicking the "Advanced" cog should set focus on the block tab #2304

jasmussen opened this issue Aug 9, 2017 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@jasmussen
Copy link
Contributor

Current behavior:

  • Select a block
  • Click the cog and the block sidebar opens
  • Press tab and you're taken to the next block

Desired behavior:

  • Select a block
  • Click the cog and the block sidebar opens, and focus is set on the first interactable element in the block sidebar
  • Press tab and you're taken to the next interactable element in the block sidebar

In addition to setting focus on the sidebar, we should visually flash the sidebar to show where focus is now. Something like this, perhaps: https://codepen.io/joen/pen/Nvjror

CC: @afercia

@jasmussen jasmussen added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Aug 9, 2017
@afercia
Copy link
Contributor

afercia commented Aug 9, 2017

@jasmussen thanks. See also:
"Keyboard navigation from blocks to the sidebar and back to blocks" #1182
where we were wondering about skip links

and #1608 (comment)

The argument there is that moving focus programmatically can be an assumption about one specific workflow, while users might want to just explore content or visually check the sidebar settings or any other workflow users will able to find 🙂

A similar feature is implemented in the Media modal: when selecting an attachment, focus gets moved to the details sidebar. This actually forces users to tab dozens (potentially hundreds) of times to get back to the attachment grid if they want to select multiple attachments or unselect the previously selected one or perform any other action outside the sidebar.
Over time, we've received lots of complaints about this feature and I'd really like to don't do the same mistake again 🙂

Also, if we're going to implement keyboard shortcuts à la Slack (and landmarks) to jump through the main UI sections as proposed in #467 (comment) maybe moving focus is not a concern any longer?

@jasmussen jasmussen added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Aug 18, 2017
@jasmussen
Copy link
Contributor Author

Closing this in favor of #1182

ceyhun pushed a commit that referenced this issue Jun 17, 2020
…b_breakage

Update GB reference to fix web breakage in Clipboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

2 participants