Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit navigation depth to 5, to avoid submenus going off the editor canvas #21691

Closed
karmatosed opened this issue Apr 17, 2020 · 6 comments · Fixed by #30199
Closed

Limit navigation depth to 5, to avoid submenus going off the editor canvas #21691

karmatosed opened this issue Apr 17, 2020 · 6 comments · Fixed by #30199
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

karmatosed commented Apr 17, 2020

If you add multiple sub navigations it can end up going off the canvas.

image

Edit: Per discussion, a good solution for starters would be to limit the navigation depth to 5.

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Apr 17, 2020
@karmatosed karmatosed added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Apr 17, 2020
@draganescu draganescu added the [Block] Navigation Affects the Navigation Block label Jun 4, 2020
@jasmussen
Copy link
Contributor

Thanks for the ticket, you are the best tester!

To an extent, though, some of this should be "allowed", insofar as if you really want to, you can break any layout with an unfortunate usage of the tools available, and by that I mean everything ranging from the spectrum of setting the font to 2px Comic Sans, to grouping a paragraph in 100 layers of groups.

What do you think, @shaunandrews?

@shaunandrews
Copy link
Contributor

I think it is weird that the submenus can nest infinitely like this; I'd expect there to be some limit on the number of nested menus.

@jasmussen
Copy link
Contributor

Good point. How about 5? That seems like it would be one more than anyone should ever need, and presumably we'd be able to easily increase that if someone wants it.

@shaunandrews
Copy link
Contributor

Makes sense to me.

@jasmussen jasmussen changed the title Navigation goes off the editor canvas with multiple sub navigations Limit navigation depth to 5, to avoid submenus going off the editor canvas Mar 1, 2021
@jasmussen
Copy link
Contributor

Tammie my friend, I took the liberty of editing the ticket here to make it about limiting the amount of nesting to 5.

@georgeh
Copy link
Contributor

georgeh commented Mar 19, 2021

👀

@georgeh georgeh self-assigned this Mar 19, 2021
georgeh pushed a commit that referenced this issue Mar 24, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 24, 2021
georgeh pushed a commit that referenced this issue Apr 6, 2021
georgeh added a commit that referenced this issue Apr 7, 2021
Removes the ability to nest submenus beyond 5 to avoid scrolling off the screen.

Closes #21691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants