-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media/Text Block: RTL styles for media alignment not working #17922
Comments
Good catch @nielslange. So is the solution we're looking for to have the block not swap left and right? Or to adjust the labels/icons to support the RTL result? |
@richtabor Either way works, as long as the image is aligned in accordance to users selection. Thus, if a user clicks on |
In the case of RTL languages, the solution is to NOT swap the image position, only the text alignment. The image position is easily fixed by just clicking the positioning icons for the block. This way the buttons represent the layout, not the language. "Media on left" is always media on left. Regardless of language, left is still left. |
@mapk Isn't that what I mentioned in #17922 (comment)? 😀 |
@nielslange definitely as you mentioned. 👍 The comments lead to two different solutions, so I just wanted to clarify what the path forward for this should be. |
I see. Thanks for clarifying this, @mapk! 🙌 |
Describe the bug
The media/image block does not respect media alignments.
To reproduce
Steps to reproduce the behavior:
/wp-admin/options-general.php
and change the site language to an RTL language, e.g. Hebrew/wp-admin/post-new.php
3.1 Media: left / Text: right
3.2 Media: right / Text: left
Expected behavior
Screenshots
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: