Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropcap tag doesn't get cleaned up #1768

Closed
hedgefield opened this issue Jul 6, 2017 · 3 comments · Fixed by #1910
Closed

Dropcap tag doesn't get cleaned up #1768

hedgefield opened this issue Jul 6, 2017 · 3 comments · Fixed by #1910
Assignees
@westonruter
Labels
[Type] Bug An existing feature does not function as intended
Milestone
Beta 0.7.0

Comments

@hedgefield
Copy link

Issue Overview

This is a minor thing, but something that triggered my clean markup spidey sense.

Steps to Reproduce

  1. Create a text block with some text
  2. Look in the code view and see: <!-- wp:core/text -->
  3. Turn the Dropcap toggle on
  4. Look in the code view and see: <!-- wp:core/text {"dropCap":true} -->
  5. Turn the Dropcap toggle off
  6. Look in the code and see that it says <!-- wp:core/text {"dropCap":false} -->

version 0.3.0

Expected Behavior

That the tag gets cleaned up after you turn dropcaps off. By default, when the tag is absent, it should assume that dropcaps are not wanted.

Current Behavior

The tag remains in the block definition.
@mtias mtias added the [Type] Bug An existing feature does not function as intended label Jul 6, 2017
@mtias mtias added this to the Beta 0.5.0 milestone Jul 6, 2017
@swissspidy
Copy link
Member

This is likely to come up again for other blocks with default attribute values. Is there a way we can fix this for all of them?

@mtias mtias modified the milestones: Beta 0.6.0, Beta 0.5.0 Jul 14, 2017
@westonruter westonruter self-assigned this Jul 15, 2017
@westonruter
Copy link
Member

Working on a patch…

@westonruter westonruter mentioned this issue Jul 15, 2017
Merged
@westonruter
Copy link
Member

Please try fix in #1910.

@mtias mtias modified the milestones: Beta 0.7.0, Beta 0.6.0 Jul 28, 2017
Tug pushed a commit that referenced this issue Jan 16, 2020
@hypest
Merge pull request #1768 from wordpress-mobile/issue/1761-video-overf…
706b981 
…low-on-android

Force the react-native-video fork to build against same RN version as gutenberg-mobile from maven repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Beta 0.7.0
Development

Successfully merging a pull request may close this issue.

Omit serializing block attributes that match any default attribute values WordPress/gutenberg
4 participants
@westonruter @mtias @swissspidy @hedgefield