Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Stock table should have some responsive CSS out of the box #1742

Closed
jasmussen opened this issue Jul 5, 2017 · 0 comments · Fixed by #2152
Closed

Table: Stock table should have some responsive CSS out of the box #1742

jasmussen opened this issue Jul 5, 2017 · 0 comments · Fixed by #2152
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Milestone
Feature Complete

Comments

@jasmussen
Copy link
Contributor

We have a table block! 🎉

But if you add long content inside the table, it's likely to add horizontal scrollbars to the entire page.

What CSS can we offer "out of the box", that would help make the table block responsive? Ideally we can do something to stack table rows. But absent that we should at least look at enabling a horizontal scrollbar on the table itself, so if it's wider than the horizontal available space, only the table scrolls.
@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks Design [Type] Enhancement A suggestion for improvement. labels Jul 5, 2017
@jasmussen jasmussen added this to the Beta, Nice To Have milestone Jul 5, 2017
jasmussen added a commit that referenced this issue Aug 2, 2017
@jasmussen
Add responsive CSS to the table out of the box
2287aaa 
This fixes #1742.

It is also extracted from #2151 because I should know better.

In this PR, if there isn't room for the table it scrolls horizontally. This works in the admin and the theme, and I think it works reasonably well. Still it might be controversial — what might be the challenges?
@jasmussen jasmussen mentioned this issue Aug 2, 2017
Merged
jasmussen added a commit that referenced this issue Aug 2, 2017
@jasmussen
Build some responsive CSS into the table
25102d6 
This fixes #1742.
mtias pushed a commit that referenced this issue Aug 4, 2017
@jasmussen @mtias
Add responsive CSS to the table out of the box (#2152)
d95faa5 
This fixes #1742.

It is also extracted from #2151 because I should know better.

In this PR, if there isn't room for the table it scrolls horizontally. This works in the admin and the theme, and I think it works reasonably well. Still it might be controversial — what might be the challenges?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Feature Complete
Development

Successfully merging a pull request may close this issue.

Add responsive CSS to the table out of the box WordPress/gutenberg
1 participant
@jasmussen