Merge pull request #133 from wordpress-mobile/feature/heading_toolbar

Heading toolbar
WordPress · Sep 8, 2018 · fb6d1f3 · fb6d1f3
2 parents 80863d7 + ec457af
commit fb6d1f3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/gutenberg b/gutenberg
diff --git a/jest.config.js b/jest.config.js
@@ -32,7 +32,7 @@ module.exports = {
 		'node',
 	],
 	moduleNameMapper: {
-		'@wordpress\\/(blocks|data|element|deprecated|editor|redux-routine|block-library|components|keycodes|url|a11y)$': '<rootDir>/gutenberg/packages/$1/src/index',
+		'@wordpress\\/(blocks|data|element|deprecated|editor|redux-routine|block-library|components|keycodes|url|a11y|viewport|core-data|api-fetch|nux)$': '<rootDir>/gutenberg/packages/$1/src/index',
 
 		// Mock the CSS modules. See https://facebook.github.io/jest/docs/en/webpack.html#handling-static-assets
 		'\\.(scss)$': '<rootDir>/__mocks__/styleMock.js',

diff --git a/src/block-management/block-holder.js b/src/block-management/block-holder.js
@@ -62,7 +62,6 @@ export default class BlockHolder extends React.Component<PropsType, StateType> {
 			style = styles.blockText;
 		}
 
-		// TODO: setAttributes needs to change the state/attributes
 		return (
 			<Block
 				attributes={ { ...this.props.attributes } }

diff --git a/src/block-management/block-manager.js b/src/block-management/block-manager.js
@@ -164,14 +164,15 @@ export default class BlockManager extends React.Component<PropsType, StateType>
 	}
 
 	onChange( clientId: string, attributes: mixed ) {
-		// Update datasource UI
+		// Update Redux store
+		this.props.onChange( clientId, attributes );
+
+		// Change the data source
 		const index = this.getDataSourceIndexFromClientId( clientId );
 		const dataSource = this.state.dataSource;
 		const block = dataSource.get( index );
 		block.attributes = attributes;
 		dataSource.set( index, block );
-		// Update Redux store
-		this.props.onChange( clientId, attributes );
 	}
 
 	renderList() {