Editor: Avoid passing event object to save button onSave prop (#16770)

WordPress · Aug 29, 2019 · fb4640e · fb4640e
1 parent f9876c2
commit fb4640e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/editor/src/components/post-saved-state/index.js b/packages/editor/src/components/post-saved-state/index.js
@@ -103,7 +103,7 @@ export class PostSavedState extends Component {
 				<IconButton
 					className="editor-post-save-draft"
 					label={ label }
-					onClick={ onSave }
+					onClick={ () => onSave() }
 					shortcut={ displayShortcut.primary( 's' ) }
 					icon="cloud-upload"
 				/>
@@ -113,7 +113,7 @@ export class PostSavedState extends Component {
 		return (
 			<Button
 				className="editor-post-save-draft"
-				onClick={ onSave }
+				onClick={ () => onSave() }
 				shortcut={ displayShortcut.primary( 's' ) }
 				isTertiary
 			>

diff --git a/packages/editor/src/components/post-saved-state/test/__snapshots__/index.js.snap b/packages/editor/src/components/post-saved-state/test/__snapshots__/index.js.snap
@@ -6,7 +6,7 @@ exports[`PostSavedState should return Save button if edits to be saved 1`] = `
 <ForwardRef(Button)
   className="editor-post-save-draft"
   isTertiary={true}
-  onClick={[MockFunction]}
+  onClick={[Function]}
   shortcut="Ctrl+S"
 >
   Save Draft

diff --git a/packages/editor/src/components/post-saved-state/test/index.js b/packages/editor/src/components/post-saved-state/test/index.js
@@ -66,7 +66,9 @@ describe( 'PostSavedState', () => {
 		);
 
 		expect( wrapper ).toMatchSnapshot();
-		wrapper.simulate( 'click' );
+		wrapper.simulate( 'click', {} );
 		expect( saveSpy ).toHaveBeenCalled();
+		// Regression: Verify the event object is not passed to prop callback.
+		expect( saveSpy.mock.calls[ 0 ] ).toEqual( [] );
 	} );
 } );