ESLint: Enable ignoreRestSiblings option for no-unused-vars rule (#…

…41897) * ESLint: Enable ignoreRestSiblings option for no-unused-vars rule * Remove unnecessary ESLint ignores * Add changelog
WordPress · Jun 27, 2022 · fa24765 · fa24765
1 parent 0f23f61
commit fa24765
Show file tree

Hide file tree

Showing 12 changed files with 9 additions and 26 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/block-library/src/comments-title/deprecated.js b/packages/block-library/src/comments-title/deprecated.js
@@ -18,13 +18,11 @@ export default [
 		},
 		supports,
 		migrate: ( oldAttributes ) => {
-			/* eslint-disable no-unused-vars */
 			const {
 				singleCommentLabel,
 				multipleCommentsLabel,
 				...newAttributes
 			} = oldAttributes;
-			/* eslint-enable no-unused-vars */
 			return newAttributes;
 		},
 		isEligible: ( { multipleCommentsLabel, singleCommentLabel } ) =>

diff --git a/packages/components/src/custom-gradient-picker/index.js b/packages/components/src/custom-gradient-picker/index.js
@@ -66,7 +66,6 @@ const GradientTypePicker = ( { gradientAST, hasGradient, onChange } ) => {
 	};
 
 	const onSetRadialGradient = () => {
-		// eslint-disable-next-line no-unused-vars
 		const { orientation, ...restGradientAST } = gradientAST;
 		onChange(
 			serializeGradient( {

diff --git a/packages/components/src/mobile/bottom-sheet/keyboard-avoiding-view.native.js b/packages/components/src/mobile/bottom-sheet/keyboard-avoiding-view.native.js
@@ -98,13 +98,8 @@ class KeyboardAvoidingView extends Component {
 	}
 
 	render() {
-		const {
-			children,
-			enabled,
-			keyboardVerticalOffset, // eslint-disable-line no-unused-vars
-			style,
-			...props
-		} = this.props;
+		const { children, enabled, keyboardVerticalOffset, style, ...props } =
+			this.props;
 
 		let finalStyle = style;
 		if ( Platform.OS === 'ios' ) {

diff --git a/packages/components/src/navigation/use-navigation-tree-nodes.js b/packages/components/src/navigation/use-navigation-tree-nodes.js
@@ -9,7 +9,6 @@ export const useNavigationTreeNodes = () => {
 	const getNode = ( key ) => nodes[ key ];
 
 	const addNode = ( key, value ) => {
-		// eslint-disable-next-line no-unused-vars
 		const { children, ...newNode } = value;
 		return setNodes( ( original ) => ( {
 			...original,
@@ -19,7 +18,6 @@ export const useNavigationTreeNodes = () => {
 
 	const removeNode = ( key ) => {
 		return setNodes( ( original ) => {
-			// eslint-disable-next-line no-unused-vars
 			const { [ key ]: removedNode, ...remainingNodes } = original;
 			return remainingNodes;
 		} );

diff --git a/packages/editor/src/components/provider/index.native.js b/packages/editor/src/components/provider/index.native.js
@@ -319,13 +319,7 @@ class NativeEditorProvider extends Component {
 	}
 
 	render() {
-		const {
-			children,
-			post, // eslint-disable-line no-unused-vars
-			capabilities,
-			settings,
-			...props
-		} = this.props;
+		const { children, post, capabilities, settings, ...props } = this.props;
 		const editorSettings = this.getEditorSettings( settings, capabilities );
 
 		return (

diff --git a/packages/element/src/serialize.js b/packages/element/src/serialize.js
@@ -646,7 +646,6 @@ export function renderNativeComponent(
 		// place of children. Ensure to omit so it is not assigned as attribute
 		// as well.
 		content = renderChildren( props.value, context, legacyContext );
-		// eslint-disable-next-line no-unused-vars
 		const { value, ...restProps } = props;
 		props = restProps;
 	} else if (

diff --git a/packages/eslint-plugin/CHANGELOG.md b/packages/eslint-plugin/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+-   Enable `no-unused-vars`'s setting `ignoreRestSiblings` to allow unused variables when destructuring with rest properties ([#41897](https://github.com/WordPress/gutenberg/pull/41897)).
+
 ## 12.2.0 (2022-05-04)
 
 ### Bug Fix

diff --git a/packages/eslint-plugin/configs/es5.js b/packages/eslint-plugin/configs/es5.js
@@ -52,7 +52,7 @@ module.exports = {
 		'no-unreachable': 'error',
 		'no-unsafe-negation': 'error',
 		'no-unused-expressions': 'error',
-		'no-unused-vars': 'error',
+		'no-unused-vars': [ 'error', { ignoreRestSiblings: true } ],
 		'no-useless-return': 'error',
 		'no-whitespace-before-property': 'error',
 		'no-with': 'error',

diff --git a/packages/eslint-plugin/configs/jshint.js b/packages/eslint-plugin/configs/jshint.js
@@ -9,7 +9,7 @@ module.exports = {
 		'no-trailing-spaces': 'error',
 		'no-undef': 'error',
 		'no-unused-expressions': 'error',
-		'no-unused-vars': 'error',
+		'no-unused-vars': [ 'error', { ignoreRestSiblings: true } ],
 		'one-var': [ 'error', 'always' ],
 		quotes: [ 'error', 'single' ],
 		'wrap-iife': [ 'error', 'any' ],

diff --git a/packages/react-native-aztec/src/AztecView.js b/packages/react-native-aztec/src/AztecView.js
@@ -214,7 +214,6 @@ class AztecView extends Component {
 	}
 
 	render() {
-		// eslint-disable-next-line no-unused-vars
 		const { onActiveFormatsChange, ...otherProps } = this.props;
 		// `style` has to be destructured separately, without `otherProps`, because of:
 		// https://github.com/WordPress/gutenberg/issues/23611

diff --git a/packages/react-native-editor/src/index.js b/packages/react-native-editor/src/index.js
@@ -36,7 +36,6 @@ const registerGutenberg = ( {
 		constructor( props ) {
 			super( props );
 
-			// eslint-disable-next-line no-unused-vars
 			const { rootTag, ...parentProps } = this.props;
 
 			// Setup locale.