add placeholder attribute and use it in the UI (#16783)

WordPress · Jul 29, 2019 · f4206ef · f4206ef
1 parent dd4d205
commit f4206ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/block-library/src/button/block.json b/packages/block-library/src/button/block.json
@@ -42,6 +42,9 @@
 			"source": "attribute",
 			"selector": "a",
 			"attribute": "rel"
+		},
+		"placeholder": {
+			"type": "string"
 		}
 	}
 }
diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js
@@ -104,14 +104,15 @@ class ButtonEdit extends Component {
 			title,
 			linkTarget,
 			rel,
+			placeholder,
 		} = attributes;
 
 		const linkId = `wp-block-button__inline-link-${ instanceId }`;
 
 		return (
 			<div className={ className } title={ title } ref={ this.bindRef }>
 				<RichText
-					placeholder={ __( 'Add text…' ) }
+					placeholder={ placeholder || __( 'Add text…' ) }
 					value={ text }
 					onChange={ ( value ) => setAttributes( { text: value } ) }
 					withoutInteractiveFormatting