Skip to content

Commit

Permalink
Update help label for Image and Media & Text blocks (#48478)
Browse files Browse the repository at this point in the history
* Changes image size description, as it causes confusion

Right now this setting causes confusion as it doesn't change the visual size, but the image dimensions, see #48395.

* Added the copy to the Image block as well

* Fix typo and make copy shorter

* Update help labels for consistency

---------

Co-authored-by: Rich Tabor <[email protected]>
  • Loading branch information
tomdevisser and richtabor authored Mar 28, 2023
1 parent a5d73b2 commit ec068b8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/block-library/src/image/image.js
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,9 @@ export default function Image( {
isResizable={ isResizable }
imageWidth={ naturalWidth }
imageHeight={ naturalHeight }
imageSizeHelp={ __(
'Select the size of the source image.'
) }
/>
</PanelBody>
</InspectorControls>
Expand Down
4 changes: 3 additions & 1 deletion packages/block-library/src/media-text/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,9 @@ function MediaTextEdit( { attributes, isSelected, setAttributes, clientId } ) {
slug={ mediaSizeSlug }
imageSizeOptions={ imageSizeOptions }
isResizable={ false }
imageSizeHelp={ __( 'Select which image size to load.' ) }
imageSizeHelp={ __(
'Select the size of the source image.'
) }
/>
) }
{ mediaUrl && (
Expand Down

0 comments on commit ec068b8

Please sign in to comment.