Skip to content

Commit

Permalink
Update image caption tagname from p to figcaption
Browse files Browse the repository at this point in the history
This change brings mobile's handling of image captinos in line
with the web. It also addresses a crash that was occurring when
the enter key was tapped to enter a new line in an image caption.
  • Loading branch information
mchowning committed Apr 15, 2019
1 parent ccf785c commit e85aa98
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/block-library/src/image/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ class ImageEdit extends React.Component {
setRef={ ( ref ) => {
this._caption = ref;
} }
tagName="p"
tagName="figcaption"
placeholder={ __( 'Write caption…' ) }
value={ caption }
onChange={ ( newCaption ) => setAttributes( { caption: newCaption } ) }
Expand Down

0 comments on commit e85aa98

Please sign in to comment.