Skip to content

Commit

Permalink
Update borderFocus to ADMIN.theme (#54425)
Browse files Browse the repository at this point in the history
* Update borderFocus to ADMIN.theme

* Fix focusBoxShadow on BorderControl

* Revert "Fix focusBoxShadow on BorderControl"

This reverts commit 751e361.

* Update CHANGELOG.md

* Update snapshots
  • Loading branch information
richtabor authored Sep 13, 2023
1 parent 8b52f85 commit dccbb46
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- `ToolbarItem`: Fix children not showing in rendered components ([#53314](https://github.com/WordPress/gutenberg/pull/53314)).
- `CircularOptionPicker`: make focus styles resilient to button size changes ([#54196](https://github.com/WordPress/gutenberg/pull/54196)).
- `InputControl`: Fix focus style size ([#54394](https://github.com/WordPress/gutenberg/pull/54394)).
- `Color values`: Update borderFocus to ADMIN.theme ([#54425](https://github.com/WordPress/gutenberg/pull/54425)).

### Internal

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports[`ToggleGroupControl controlled should render correctly with icons 1`] =
}
.emotion-8:focus-within {
border-color: var(--wp-components-color-accent-darker-10, var(--wp-admin-theme-color-darker-10, #2145e6));
border-color: var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
box-shadow: 0 0 0 0.5px var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
z-index: 1;
outline: 2px solid transparent;
Expand Down Expand Up @@ -380,7 +380,7 @@ exports[`ToggleGroupControl controlled should render correctly with text options
}
.emotion-8:focus-within {
border-color: var(--wp-components-color-accent-darker-10, var(--wp-admin-theme-color-darker-10, #2145e6));
border-color: var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
box-shadow: 0 0 0 0.5px var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
z-index: 1;
outline: 2px solid transparent;
Expand Down Expand Up @@ -598,7 +598,7 @@ exports[`ToggleGroupControl uncontrolled should render correctly with icons 1`]
}
.emotion-8:focus-within {
border-color: var(--wp-components-color-accent-darker-10, var(--wp-admin-theme-color-darker-10, #2145e6));
border-color: var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
box-shadow: 0 0 0 0.5px var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
z-index: 1;
outline: 2px solid transparent;
Expand Down Expand Up @@ -915,7 +915,7 @@ exports[`ToggleGroupControl uncontrolled should render correctly with text optio
}
.emotion-8:focus-within {
border-color: var(--wp-components-color-accent-darker-10, var(--wp-admin-theme-color-darker-10, #2145e6));
border-color: var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
box-shadow: 0 0 0 0.5px var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9));
z-index: 1;
outline: 2px solid transparent;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/utils/colors-values.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const UI = {
backgroundDisabled: GRAY[ 100 ],
border: GRAY[ 600 ],
borderHover: GRAY[ 700 ],
borderFocus: ADMIN.themeDark10,
borderFocus: ADMIN.theme,
borderDisabled: GRAY[ 400 ],
textDisabled: GRAY[ 600 ],
textDark: white,
Expand Down

1 comment on commit dccbb46

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in dccbb46.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6173873925
📝 Reported issues:

Please sign in to comment.