MediaReplaceFlow: Avoid React warning when selecting media (#34618)

* MediaReplaceFlow: Avoid React warning when selecting media * Add inline comment
WordPress · Sep 17, 2021 · d4674c7 · d4674c7
1 parent 4f3d93e
commit d4674c7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/block-editor/src/components/media-replace-flow/index.js b/packages/block-editor/src/components/media-replace-flow/index.js
@@ -77,8 +77,9 @@ const MediaReplaceFlow = ( {
 	};
 
 	const selectMedia = ( media ) => {
-		onSelect( media );
 		setMediaURLValue( media.url );
+		// Calling `onSelect` after the state update since it might unmount the component.
+		onSelect( media );
 		speak( __( 'The media file has been replaced' ) );
 		removeNotice( errorNoticeID );
 	};