WIP

WordPress · Nov 23, 2022 · d211a80 · d211a80
1 parent fc4c4cd
commit d211a80
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 0 deletions.
diff --git a/packages/components/src/number-control/stories/index.tsx b/packages/components/src/number-control/stories/index.tsx
@@ -58,3 +58,23 @@ export const Default = Template.bind( {} );
 Default.args = {
 	label: 'Value',
 };
+
+// Check if this was broken and at what point
+// in particular on commit actions, when `min` is not `undefined`
+
+export const Uncontrolled = ( { onChange, ...props } ) => {
+	const [ isValidValue, setIsValidValue ] = useState( true );
+
+	return (
+		<>
+			<NumberControl
+				{ ...props }
+				onChange={ ( v, extra ) => {
+					setIsValidValue( extra.event.target.validity.valid );
+					onChange( v, extra );
+				} }
+			/>
+			<p>Is valid? { isValidValue ? 'Yes' : 'No' }</p>
+		</>
+	);
+};
diff --git a/packages/components/src/number-control/utils.ts b/packages/components/src/number-control/utils.ts
@@ -7,3 +7,5 @@ export const computeStep = ( {
 	baseStep: number;
 	enableShift?: boolean;
 } ) => ( enableShift ? shiftStep * baseStep : baseStep );
+
+// Move spin and constrain here?
diff --git a/packages/components/src/utils/test/values.js b/packages/components/src/utils/test/values.js
@@ -99,3 +99,5 @@ describe( 'isValueNumeric', () => {
 		} );
 	} );
 } );
+
+// TODO: ensureNumber / ensureString tests
diff --git a/packages/components/src/utils/values.js b/packages/components/src/utils/values.js
@@ -125,6 +125,7 @@ export const numberToString = ( value ) => {
  * @return {number} The parsed number.
  */
 export const ensureNumber = ( value ) => {
+	// TODO: how to translate empty string?
 	return typeof value === 'string' ? stringToNumber( value ) : value;
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -99,3 +99,5 @@ describe( 'isValueNumeric', () => { @@
     		} );
     	} );
     } );
+    // TODO: ensureNumber / ensureString tests