Skip to content

Commit

Permalink
Update MiniCSSExtractPlugin to version 2.5.1 (#38027)
Browse files Browse the repository at this point in the history
* update mini-css-extract-plugin to version 2.5.1

* remove temporary workaround added for CommonJS import issue in version 2.5.0 of  MiniCSSExtractPlugin
  • Loading branch information
fabiankaegy authored Jan 18, 2022
1 parent e1978ea commit b852219
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
20 changes: 13 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/scripts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
### Bug Fixes

- Prevent the `CleanWebpackPlugin` plugin from deleting webpack assets during multi-configuration builds [#35980](https://github.com/WordPress/gutenberg/issues/35980).
- Remove temporary workaround fixing CommonJS import for `mini-css-extract-plugin` [#38027](https://github.com/WordPress/gutenberg/pull/38027).

### Internal

Expand Down
9 changes: 1 addition & 8 deletions packages/scripts/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,7 @@ const { BundleAnalyzerPlugin } = require( 'webpack-bundle-analyzer' );
const { CleanWebpackPlugin } = require( 'clean-webpack-plugin' );
const CopyWebpackPlugin = require( 'copy-webpack-plugin' );
const browserslist = require( 'browserslist' );

/*
* Temporary workaround to fix broken CommonJS import in version 2.5.0.
* @see https://github.com/WordPress/gutenberg/issues/37992
*/
const MiniCSSExtractPlugin = require( 'mini-css-extract-plugin' ).default
? require( 'mini-css-extract-plugin' ).default
: require( 'mini-css-extract-plugin' );
const MiniCSSExtractPlugin = require( 'mini-css-extract-plugin' );
const { basename, dirname, resolve } = require( 'path' );
const ReactRefreshWebpackPlugin = require( '@pmmmwh/react-refresh-webpack-plugin' );
const TerserPlugin = require( 'terser-webpack-plugin' );
Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"markdownlint": "^0.23.1",
"markdownlint-cli": "^0.27.1",
"merge-deep": "^3.0.3",
"mini-css-extract-plugin": "^2.5.0",
"mini-css-extract-plugin": "^2.5.1",
"minimist": "^1.2.0",
"npm-package-json-lint": "^5.0.0",
"npm-packlist": "^3.0.0",
Expand Down

0 comments on commit b852219

Please sign in to comment.