update snapshot, tune windowOverscan to 40 instead of visibleitems

WordPress · Oct 28, 2021 · 96a183f · 96a183f
1 parent 0113349
commit 96a183f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/packages/block-editor/src/components/block-switcher/test/__snapshots__/index.js.snap b/packages/block-editor/src/components/block-switcher/test/__snapshots__/index.js.snap
@@ -6,7 +6,7 @@ exports[`BlockSwitcherDropdownMenu should render disabled block switcher with mu
     className="block-editor-block-switcher__no-switcher-icon"
     disabled={true}
     icon={
-      <BlockIcon
+      <Memo(BlockIcon)
         icon={
           <SVG
             viewBox="0 0 24 24"

diff --git a/packages/block-editor/src/components/list-view/index.js b/packages/block-editor/src/components/list-view/index.js
@@ -111,6 +111,7 @@ function ListView(
 		visibleBlockCount,
 		{
 			useWindowing: __experimentalPersistentListViewFeatures,
+			windowOverscan: 40,
 		}
 	);
 

diff --git a/packages/compose/src/hooks/use-fixed-window-list/index.js b/packages/compose/src/hooks/use-fixed-window-list/index.js
@@ -60,14 +60,19 @@ export default function useFixedWindowList(
 			return;
 		}
 		const scrollContainer = getScrollContainer( elementRef.current );
-		const measureWindow = () => {
+		const measureWindow = (
+			/** @type {boolean | undefined} */ initRender
+		) => {
 			if ( ! scrollContainer ) {
 				return;
 			}
 			const visibleItems = Math.ceil(
 				scrollContainer.clientHeight / itemHeight
 			);
-			const windowOverscan = options?.windowOverscan ?? visibleItems;
+			// Aim to keep opening list view fast, afterward we can optimize for scrolling
+			const windowOverscan = initRender
+				? visibleItems
+				: options?.windowOverscan ?? visibleItems;
 			const firstViewableIndex = Math.floor(
 				scrollContainer.scrollTop / itemHeight
 			);
@@ -96,7 +101,7 @@ export default function useFixedWindowList(
 			} );
 		};
 
-		measureWindow();
+		measureWindow( true );
 		const debounceMeasureList = debounce( () => {
 			measureWindow();
 		}, 16 );
-Original file line number
+Diff line change
@@ Expand Up / @@ -111,6 +111,7 @@ function ListView( @@
     		visibleBlockCount,
     		{
     			useWindowing: __experimentalPersistentListViewFeatures,
+    			windowOverscan: 40,
     		}
     	);
@@ Expand Down @@