Remove empty attrs. (#54496)

* Remove empty attrs. * Fix linter errors --------- Co-authored-by: Sarah Norris <[email protected]>
WordPress · Oct 13, 2023 · 8fa0d97 · 8fa0d97 · github-actions · Oct 14, 2023
1 parent f07b815
commit 8fa0d97
Showing 1 changed file with 6 additions and 15 deletions.
diff --git a/packages/block-serialization-default-parser/class-wp-block-parser.php b/packages/block-serialization-default-parser/class-wp-block-parser.php
@@ -48,14 +48,6 @@ class WP_Block_Parser {
 	 */
 	public $stack;
 
-	/**
-	 * Empty associative array, here due to PHP quirks
-	 *
-	 * @since 4.4.0
-	 * @var array empty associative array
-	 */
-	public $empty_attrs;
-
 	/**
 	 * Parses a document and returns a list of block structures
 	 *
@@ -69,11 +61,10 @@ class WP_Block_Parser {
 	 * @return array[]
 	 */
 	public function parse( $document ) {
-		$this->document    = $document;
-		$this->offset      = 0;
-		$this->output      = array();
-		$this->stack       = array();
-		$this->empty_attrs = array();
+		$this->document = $document;
+		$this->offset   = 0;
+		$this->output   = array();
+		$this->stack    = array();
 
 		while ( $this->proceed() ) {
 			continue;
@@ -287,7 +278,7 @@ public function next_token() {
 		 */
 		$attrs = $has_attrs
 			? json_decode( $matches['attrs'][0], /* as-associative */ true )
-			: $this->empty_attrs;
+			: array();
 
 		/*
 		 * This state isn't allowed
@@ -318,7 +309,7 @@ public function next_token() {
 	 * @return WP_Block_Parser_Block freeform block object.
 	 */
 	public function freeform( $inner_html ) {
-		return new WP_Block_Parser_Block( null, $this->empty_attrs, array(), $inner_html, array( $inner_html ) );
+		return new WP_Block_Parser_Block( null, array(), array(), $inner_html, array( $inner_html ) );
 	}
 
 	/**