useBlockProps: fix selection scroll into view ref (#31835)

packages/block-editor/src/components/block-list/use-block-props/use-scroll-into-view.js

@@ -34,13 +34,20 @@ export function useScrollIntoView( clientId ) {
 		[ clientId ]
 	);
 
+	// Note that we can't use `useRefEffect` here, since an element change does
+	// not mean we can scroll. `isSelectionEnd` should be the sole dependency,
+	// while with `useRefEffect`, the element is a dependency as well.
 	useEffect( () => {
 		if ( ! isSelectionEnd ) {
 			return;
 		}
 
 		const extentNode = ref.current;
 
+		if ( ! extentNode ) {
+			return;
+		}
+
 		// If the block is focused, the browser will already have scrolled into
 		// view if necessary.
 		if ( extentNode.contains( extentNode.ownerDocument.activeElement ) ) {

packages/block-library/src/post-featured-image/edit.js

@@ -119,14 +119,10 @@ function PostFeaturedImageDisplay( {
 
 const PostFeaturedImageWithNotices = withNotices( PostFeaturedImageDisplay );
 
-const OutofContextPlaceholder = () => {
-	const blockProps = useBlockProps();
-	return <div { ...blockProps }>{ placeholderChip }</div>;
-};
-
 export default function PostFeaturedImageEdit( props ) {
+	const blockProps = useBlockProps();
 	if ( ! props.context?.postId ) {
-		return <OutofContextPlaceholder />;
+		return <div { ...blockProps }>{ placeholderChip }</div>;
 	}
 	return <PostFeaturedImageWithNotices { ...props } />;
 }